1. Apply some Custom paragraph styles to text in a document. 2. Select "Replace Custom Styles" in Tools > AutoCorrect > AutoCorrect Options - Options tab. 3. Run "Tools > AutoCorrect > Apply In general, Custom Styles are replaced by this command with "Text Body" PS Exceptions: 1. Have been able to get custom styles converted to: - Text Body Indent (when "Before text indent" attribute is used) - Hanging Indent (when "First line indent" and "Before text indent" used) - First Line Indent (when "First line indent" is used) 2. Paragraph Style with four-sided border was NOT converted. Copied from bug 90507, comment 11 > 'Replace Custom Styles' has some interesting behavior as well. > > Not clear if those are relative to the Standard Template, or to the > Template used to create the document--but its action when applied is > to remove other PS and revert to something present in the template. > > So, makes me wonder exactly what is considered a "custom" style as related > to the AutoFormat in (editeng/acorrcfg.hxx & acorrcfg.cxx)? Copied from bug 90507 comment 17 > Need to verify the handling of 'custom' styles, what constitutes them and > how are they made non-custom so can be protected from the 'Replace Custom > Styles' action. > > Results of the 'Replace Custom Styles' action seems error prone to > document layout at best. > Well we should improve the documentation, obviously. Have made some modifications in relation to observed behavior. Can documentation be improved further? Does command work as intended?
+1
Dear sdc.blanco, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
(In reply to V Stuart Foote from comment #1) > +1 bug 90507 comment 22 acknowledges the issues here, but does not provide any additional information or clarification about expected behavior, in light of the points copied into OP. Meanwhile, from some (limited) experiments with 7.6.0.0.alpha0+, it seems that "empty" paragraphs with Custom Styles are not converted. Now filed as bug 153424. It is not clear whether documentation can/should be improved further or whether UXEval is needed to decide on "expected behavior".
(In reply to sdc.blanco from comment #0) > 2. Paragraph Style with four-sided border was NOT converted. Can't confirm with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded I've created a new PS, based on Numbering5 and only added four-sided border.
I think the "Replace Custom Styles" option should be removed from AutoCorrect. 1. The Find and Replace dialog gives a flexible, extensive, transparent way to change PS. 2. There are already many options in AutoCorrect, and the current behavior of Replace Custom Styles is limited (and of questionable value), so it would be good to reduce the number of options. 3. AutoCorrect should not be used to change PS. The "correct" in AutoCorrect should be limited to "replacements" (e.g., spelling, spaces, dashes, formatting).
Now that bug 90507 is fixed and Tools - AutoCorrect - Apply no longer converts "Default Paragraph Style" to "Body Text", it seems time to also remove "Replace Custom Styles" from the [M] options. Will ask UXEval -- also because maybe it is an EasyHack.
Looking at that checkbox, I really don't see how a user is supposed to understand what it does. "Custom Styles" - is that Direct Formatting, or styles the users has defined and named? If it's the latter - I don't see why these should be replaced; if it's the former - why call them this? Also - what kinds of DF would be replaced? And DF of what - characters? paragraphs? lists? And what will the target of replacement be? I even went and read the help, where it says: > Replaces custom paragraph styles applied in the current > document to "Text Body", "Text Body Indent", > "First Line Indent" or "Hanging Indent" paragraph style. I don't understand why these styles, whether they would be modified by the autocorrect process, and how it would choose among these. Can someone explain what is the original rationale for this, so that we can form an opinion of whether to keep or remove?
Have we decided to keep or remove it?
We discussed the topic in the design meeting. The label "Replace Custom Styles" is somewhat unclear, the removal wouldn't be realized by many users anyway and the recently introduced Spotlight feature shows styles clearly allowing to spot custom styles and to convert it manually. However, if one receives a document from someone else eg. created with some other application, s/he might want to replace all "alien" styles with something reasonable. So having the option is beneficial. We also discussed the label, and it's actually clear. Any style listed under Custom Styles will be replaced by Body Text and co (unclear when the latter are used). Renaming is not necessary, perhaps some improvements at the help makes sense. But since the feature is confusing many we suggest to switch it off by default. Code pointer: https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Writer.xcs?r=13393246#4233 (ReplaceUserStyle => value = false)
(In reply to Heiko Tietze from comment #9) > However, if one receives a document from someone else eg. created with some > other application, s/he might want to replace all "alien" styles with > something reasonable. So having the option is beneficial. I think that particular use case needs its own attention. If I wanted replacements of styles in an imported document, I would want to: 1. Do that explicitly, either during import or with a command for just this replacement. 2. Be told clearly what the replacement logic is going to be. 3. Be able to control what gets replaced, and perhaps aspects of how the replacement happens. ... and without these, I would probably not want LO to do such replacements for me. I certainly would not want them to happen as part of AutoCorrect. > The label "Replace Custom Styles" is somewhat unclear ... We also discussed the label, and it's actually clear. So, it's somewhat unclear, but actually clear? > Any style listed under Custom Styles will be replaced... The user will not be able to guess what "Custom Styles" are. Yes, if you look at the style sidebar and the filtering drop-down box at the bottom, one of the items is "Custom Styles", but that's one out of 12 or 13 items; and those items also include "Special Styles" for example. Does the user know when a style is "custom"? Or when it is "special" as opposed to "custom"? Without taking time to leave the AutoCorrect dialog and play with the styles bar - which they may not even be aware they need to? No, this is not clear. > ... replaced by Body Text and co(unclear when the latter are used). So, unclear again what kind of replacement is going to be made. > Renaming is not necessary, It most certainly is. > perhaps some improvements at the help makes sense. First one should make the UI clear, then (re-)document it. > But since the feature is confusing many we suggest to switch it off by > default. Sounds like the reasonable choice.
start working on this
the option is off by default after this fix for tdf#156165: https://gerrit.libreoffice.org/c/core/+/154144