Description: There is a "Collect usage data…" section and checkbox in the LibreOffice general options. However, if I correctly understand 115712 correctly, we currently can't collect any data. Steps to Reproduce: 1. Open a LibreOffice application 2. Open Tools/Options 3. Go to Libreoffice/General 4. Toggle checkbox "Collect usage data…" Actual Results: I can check the checkbox but no data is collected. Expected Results: Don’t have the checkbox (or actually collect usage data when checked) Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.4.2
Related to: https://bugs.documentfoundation.org/show_bug.cgi?id=115712
sfx2/source/control/unoctitm.cxx collectUsageInformation() Introduced with bug 96434, help at https://help.libreoffice.org/7.0/en-US/text/shared/optionen/01010600.html; works when LO_COLLECT_USAGE is set https://wiki.documentfoundation.org/Development/Environment_variables Unclear how to store data and/or what is sent.
Let's do it. Most simple and safe way is to make the labels hidden in cui/uiconfig/ui/optgeneralpage.ui.
Maybe I can do this. @Heiko Tietze I can see some Collect Data related tag in that .ui, which should I change them to False?
(In reply to Po-Yen Huang from comment #4) > Maybe I can do this. > @Heiko Tietze I can see some Collect Data related tag in that .ui, which > should I change them to False? The UI element collectusageinfo is assigned to m_xCollectUsageInfo in optgdlg.cxx. All code here just stores what is set in the UI. Hide the controls or remove it and users will not see this option. The function collectUsageInformation() in unoctitm.cxx checks the command line parameter LO_COLLECT_USAGE and the UI checkbox, collects all information around the current UNO command and stores everything with the theUsageInfo class. Up to you whether you remove all this code too - or just hide the controls, which only requires Glade to load and modify the ui file.
(In reply to Heiko Tietze from comment #5) > (In reply to Po-Yen Huang from comment #4) > > Maybe I can do this. > > @Heiko Tietze I can see some Collect Data related tag in that .ui, which > > should I change them to False? > > The UI element collectusageinfo is assigned to m_xCollectUsageInfo in > optgdlg.cxx. All code here just stores what is set in the UI. Hide the > controls or remove it and users will not see this option. > > The function collectUsageInformation() in unoctitm.cxx checks the command > line parameter LO_COLLECT_USAGE and the UI checkbox, collects all > information around the current UNO command and stores everything with the > theUsageInfo class. > > Up to you whether you remove all this code too - or just hide the controls, > which only requires Glade to load and modify the ui file. Is it safe to remove this feature for all?
(In reply to Po-Yen Huang from comment #6) > Is it safe to remove this feature for all? Your patch that removes code could be reverted if collecting user data becomes a topic again. But it was never fully productive to my knowledge and I doubt such user metrics will be accepted at all with all the privacy debates in the past years.
(In reply to Heiko Tietze from comment #7) > (In reply to Po-Yen Huang from comment #6) > > Is it safe to remove this feature for all? > > Your patch that removes code could be reverted if collecting user data > becomes a topic again. But it was never fully productive to my knowledge and > I doubt such user metrics will be accepted at all with all the privacy > debates in the past years. OK, I uploaded patch for this issue to Gerrit: https://gerrit.libreoffice.org/c/core/+/119166
Jeff Huang committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2c0b84dc65739bfc47dca684e819717eb9cce387 tdf#140107 Remove all collect usage data code. It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/6797558a82f83a50b469f38897ffe3b04218cb45 Help: tdf#140107 drop usage data; tdf#107471 describe crash reports
Verified. Fixed. The dialog is check boxes are not there anymore. Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
It will be nice if we can see it in 7.2 :-)
(In reply to Po-Yen Huang from comment #12) > It will be nice if we can see it in 7.2 :-) Too late, UI freeze was on week 27, see https://wiki.documentfoundation.org/ReleasePlan/7.2
(In reply to Xisco Faulí from comment #13) > (In reply to Po-Yen Huang from comment #12) > > It will be nice if we can see it in 7.2 :-) > > Too late, UI freeze was on week 27, see > https://wiki.documentfoundation.org/ReleasePlan/7.2 Anyway, at lease we have it 7.3 :-)