Description: Plenty of styles created on DOCX export which clearly not needed Steps to Reproduce: 1. Open the attached file 2. Save as DOCX 3. File reload 4. Go to character styles.. notice a whole list of additional styles 5. CTRL+A 6. CTRL+C 7. CTRL+V 8. Save 9. File reload -> Most of the crap gone 10. Save to ODT -> Still no crap 1. Open the attached file 2. Save as DOCX 3. File reload 4. Go to character styles.. notice a whole list of additional styles 5. Save to ODT -> ODT filled with junk Actual Results: Plenty of junk styles.. and those styles opening/saving files pretty slow Expected Results: Less junk makes managing styles lovelier & speed-up Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 169550 [details] Example file
@Justin We had a bug about this somewhere.. And if I the styles code was to horribly broken (and to complex). But this might give an approach to to get rid of most of the junk styles without a big re-factoring
Specifically, these are character styles ListLabel1 - ListLabel171. A second round-trip brings it to ListLabel225. A similar report for DOC is bug 133410 which says, see LO 5.0.6's tdf#95213 DOCX import: don't reuse list label styles. which was mollified somewhat by LO 6.3's tdf#92335 DOCX: fix multiplying of "ListLabel" styles. Especially important is "However, making a change here would be fraught with danger."
@Miklos I do perceive the whole Style creation as an rather substantial issue (usability, navigator mess + slow file opening at some point). However Justin already pointed out this being 'fraught with danger'. So this needs someone with lots of expertise (and loving to clean-up potential fall-out) However no clue who is up to the task (nor how much time/budget this would involve). So my way of 'raising awareness' (say ESC). In the hopes someone will accept the challenge (some day) (In reply to Justin L from comment #3) > Specifically, these are character styles ListLabel1 - ListLabel171. A second > round-trip brings it to ListLabel225. > > A similar report for DOC is bug 133410 which says, > see LO 5.0.6's tdf#95213 DOCX import: don't reuse list label styles. > > which was mollified somewhat by LO 6.3's tdf#92335 DOCX: fix multiplying of > "ListLabel" styles. > > Especially important is "However, making a change here would be fraught with > danger."
If you want to put something to the ESC agenda, just reply to the agenda emails on the dev list and come to the ESC call. Thanks. The current one is here: https://lists.freedesktop.org/archives/libreoffice/2021-March/086942.html If you don't feel like coming to that call, then just send a mail to the dev list, so more people can take part in the discussion.
I think the problem here is at import time. Doing this: Steps to Reproduce: 1. Open the attached file 2. Save as DOCX 3. File reload 4. Go to character styles.. notice a whole list of additional styles does not result in extra character styles being saved to the docx files styles.xml (since bug #92335 was fixed). These extra styles appear only at docx import time, then these can be saved to odt (unfortunately).
Created attachment 170749 [details] Simple reproducer file
Created attachment 170750 [details] The reproducer document saved to docx
Created attachment 170751 [details] The docx version of the reproducer saved back to odt This has the extra character styles saved to sytles.xml
Created attachment 170752 [details] The original reproducer and its docx version The problem starts at the docx import.
Created attachment 170753 [details] The docx version and the odt saved from it Once these fake ListLabel character styles are created they are saved to odt. Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2fb274950e5207ca55f4f52325fb522bd44024e1 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: CL
(In reply to NISZ LibreOffice Team from comment #11) > Once these fake ListLabel character styles are created they are saved to odt. I don't think we would want to do anything to try and stop this though. However, one possibility would be to create a "clean up document" tool that goes through and removes excess styles, obsolete direct formatting, etc. (This, of course, is a HUGE enhancement idea, and so far we can't even get someone to write a compress-all-pictures tool...)
*** Bug 143237 has been marked as a duplicate of this bug. ***
(In reply to Justin L from comment #12) > (In reply to NISZ LibreOffice Team from comment #11) > > Once these fake ListLabel character styles are created they are saved to odt. > > I don't think we would want to do anything to try and stop this though. Why? I mean, if styles are generated artifically, why not prevent that from happening? Or at least, use more stringent criteria to decide when a style is generated? > However, one possibility would be to create a "clean up document" tool that > goes through and removes excess styles, obsolete direct formatting, etc. > (This, of course, is a HUGE enhancement idea, and so far we can't even get > someone to write a compress-all-pictures tool...) and it would also be a separate bug IMHO.
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug