Bug 140271 - EMF Displayed lines are too thin and have equal line weight
Summary: EMF Displayed lines are too thin and have equal line weight
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: All All
: medium normal
Assignee: Bartosz
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-02-08 17:54 UTC by faludiz
Modified: 2021-03-22 10:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample EMF file (107.56 KB, image/x-emf)
2021-02-08 17:55 UTC, faludiz
Details
it should look like this (175.08 KB, image/png)
2021-02-08 17:57 UTC, faludiz
Details
EMF file under macOS (894.82 KB, image/png)
2021-02-11 18:08 UTC, Bartosz
Details
EMF file displayed on Linux with LO master (244.21 KB, image/png)
2021-03-17 12:16 UTC, Bartosz
Details
EMF file exported with Paint to PNG (355.35 KB, image/png)
2021-03-17 13:29 UTC, Bartosz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description faludiz 2021-02-08 17:54:29 UTC
Description:
In LO 7.0.4 and 7.1 EMF images shown ugly. Missing linewitgths, symbols, etc.
But 7.0.3 is fine!

Steps to Reproduce:
1. update to 7.0.4 or 7.1
2. insert an EMF image
3. be amazed

Actual Results:
rollback to 7.0.3

Expected Results:
EMF images looks fine with 7.1


Reproducible: Always


User Profile Reset: No



Additional Info:
problematic versions uninstalled, this works fine:

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL
Comment 1 faludiz 2021-02-08 17:55:28 UTC
Created attachment 169596 [details]
sample EMF file
Comment 2 faludiz 2021-02-08 17:57:53 UTC
Created attachment 169597 [details]
it should look like this
Comment 3 pavlog 2021-02-08 19:17:34 UTC
Thanks for reporting, I can confirm that the file looks much worse in

Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

and in 

Version: 7.2.0.0.alpha0+ (x64)
Build ID: ecb916667b633f8647790e040226b093760e6cfe
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 4 Bartosz 2021-02-11 18:08:55 UTC
Created attachment 169688 [details]
EMF file under macOS

It looks ok with version:

Version: 7.0.4.2
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 8; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 raal 2021-02-20 23:31:40 UTC
Looks good in Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 7b649f835cc00ed76927c6821a135605609bed4e
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Only the width of some lines lost. Bisected to this commit with repo linux-64-7.1$ :
 275d057f700156269f8c9f229a8f4f44e452c285 is the first bad commit
commit 275d057f700156269f8c9f229a8f4f44e452c285
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sat Nov 14 18:51:13 2020 +0100

    source eb2fdd9bc6696732fa472f6883993334898cef7a

commit eb2fdd9bc6696732fa472f6883993334898cef7a	[log]
author	Bartosz Kosiorek <gang65@poczta.onet.pl>	Fri Nov 13 13:24:36 2020 +0100
committer	Tomaž Vajngerl <quikee@gmail.com>	Sat Nov 14 18:12:42 2020 +0100
tree edf9b24fdedf5f84c0254a5b11c5f131a7befbb7
parent b0b78838e795fcd7f3c53e7f74fb32b2921a5ccb [diff]

tdf#35986 EMF import: Add support for PS_COSMETIC line style in CREATEPEN

Adding CC to:Bartosz Kosiorek
Comment 6 Bartosz 2021-03-17 12:16:52 UTC
Created attachment 170529 [details]
EMF file displayed on Linux with LO master

Reproduce on LO master:

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: b6850b9827a13b8f8d9b9749a982e128b7e0e867
CPU threads: 12; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL
Comment 7 Bartosz 2021-03-17 13:29:59 UTC
Created attachment 170531 [details]
EMF file exported with Paint to PNG
Comment 8 Commit Notification 2021-03-19 08:00:59 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/54a8aefa3372dce3da7cf0ad846d55d1b7b92467

tdf#35986 tdf#140271 EMF Fix line width of CREATEPEN record

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-03-22 10:57:55 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/8932c8906ff31f0f50f7478d41821506b0941cdf

tdf#35986 tdf#140271 EMF Fix line width of CREATEPEN record

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.