Bug 140314 - Use hub.libreoffice.org URL with appropriate parameters in Extensions button in Start Center
Summary: Use hub.libreoffice.org URL with appropriate parameters in Extensions button ...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: All All
: medium normal
Assignee: venetia
URL:
Whiteboard: reviewed:2023 target:24.2.0
Keywords: difficultyBeginner, easyHack, skillCpp
: 153620 (view as bug list)
Depends on:
Blocks: Start-Center
  Show dependency treegraph
 
Reported: 2021-02-10 09:32 UTC by Paolo Benvenuto
Modified: 2024-08-05 12:17 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Benvenuto 2021-02-10 09:32:24 UTC
Italian localization

When no document is opened, the Extensions button in the bottom left points to https://extensions.libreoffice.org/it , which doesn't exist
Comment 1 Julien Nabet 2021-02-10 21:25:09 UTC
I confirm this.
For some languages it works: fr, es, de, but for others not: it, lt, ...
Comment 2 QA Administrators 2023-02-11 03:24:04 UTC Comment hidden (obsolete)
Comment 3 Paolo Benvenuto 2023-02-13 02:00:03 UTC
Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: es-DO (it_IT.UTF-8); UI: it-IT
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.1
Calc: threaded

CONFIRMED
Comment 4 Buovjaga 2023-02-15 13:05:49 UTC
*** Bug 153620 has been marked as a duplicate of this bug. ***
Comment 5 Buovjaga 2023-02-15 13:11:20 UTC
Yep, the new site does not support localisation yet: https://redmine.documentfoundation.org/issues/3607

So I guess the URL construction should be changed to not do that.

Code pointer:
https://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/backingwindow.cxx?r=1490923b#522

The extension site URL is in "AddFeatureURL". It is localised with localizeWebserviceURI function (which should not happen).
Comment 6 Christian Lohmaier 2023-02-15 14:11:01 UTC
any non-essential URLs should ideally use the hub.libreoffice.org style URLs and pass the LO version along with the UI language as parameters. That way the missing pages can be added as time goes on and as they become available/without having to wait for an updated version of LO to be released.

See examples in sfx2/source/appl/appserv.cxx
Comment 7 Buovjaga 2023-11-03 06:07:07 UTC
Patch https://gerrit.libreoffice.org/c/core/+/155571
Comment 8 Commit Notification 2023-11-03 10:50:19 UTC
Venetia Furtado committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4af07053517ba3526d4050ffc29993a65b54352b

tdf#140314:Use hub.libreoffice.org URL with params in Extensions

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Buovjaga 2024-08-05 12:17:29 UTC
The infra task related to this is https://redmine.documentfoundation.org/issues/3693

Venetia: feel free to close as fixed.