Description: the setting "empty string is null" of text box controls is always "no", as opposed to the state saved in the XML file as form:convert-empty-to-null="true" attribute to the form:textarea XML tag. Steps to Reproduce: 1. open attached writer file 2. menu "Form", enter Design mode 3. right click on the text box 4. "control properties" 5. tab "data", look at setting "Empty String is NULL" 6. set it to "Yes" 7. save 8. close file 9. open saved file 10. look at the setting Actual Results: LibreOffice 7.1 step 5: state is "no" step 10: state is "no" LibreOffice 6.4 step 5: state is "yes" step 10: state is "yes" Expected Results: state is "yes" in all versions Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.1.0.3 / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.utf8); UI: en-GB Calc: threaded
Created attachment 169836 [details] reproduction case in Writer
Created attachment 169837 [details] reproduction case in Base
For the base version: Steps to Reproduce: 1. open attached base (odb) file 2. left part of the main screen, click on "forms" 3. bottom-right, right-click on "Tasks" 4. In pop-up menu, take "edit" 5. ctrl-click on the gray area next to "description" to select it 6. right click on the same gray area 7. control properties 8. data / empty string is null 9. observe the value 10. set it to "Yes" 11. save the form 12. close the form (not the odb file) 13. repeat steps 3 to 9 Actual Results: LibreOffice 7.1 step 9: state is "no" step 13: state is "no" LibreOffice 6.4 step 9: state is "yes" step 13: state is "yes" Expected Results: state is "yes" in all versions
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3de38e95561ab7ca114d9f3307702ba89c4e3e9a author Noel Grandin <noelgrandin@gmail.com> 2020-11-10 19:20:06 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2020-11-11 06:33:53 +0100 commit 3de38e95561ab7ca114d9f3307702ba89c4e3e9a (patch) tree 5d4c84a81e68897f325f67bc92b326ae48805f9a parent cc1e6ee2dd4609c27cb7a09aa47a779592a3e22c (diff) use fastparser in forms Bisected with: bibisect-linux64-7.1 Adding Cc: to Noel Grandin Note: the issue is reproducible at import time. No need to follow all the steps in the description
this appears to be a duplicate of #140198, which I have just fixed
(In reply to Noel Grandin from comment #5) > this appears to be a duplicate of #140198, which I have just fixed oh nice, closing as duplicated then *** This bug has been marked as a duplicate of bug 140198 ***
it seems the issue is still reproducible even with https://cgit.freedesktop.org/libreoffice/core/commit/?id=63d14566ba93b87f23a7ba68f8ea733cf19be101, reopening
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/67db5b7c8df4aa0fab08ac2d11b732dbc28c4c62 tdf#140486 forms "empty string is null" setting not loaded It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/e8a598aae891a4789e770566b87e11a47015c530 tdf#140486 forms "empty string is null" setting not loaded It will be available in 7.1.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 7b649f835cc00ed76927c6821a135605609bed4e CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Noel, thanks for fixing this issue!!
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-1-1": https://git.libreoffice.org/core/commit/0caab7456935b3ce4eeaae4dec919d7407a32af9 tdf#140486 forms "empty string is null" setting not loaded It will be available in 7.1.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/04718c6c7ffa80416dd1d44bde3f3842fb9e979f tdf#140486: sw: Add UItest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.