Bug 140661 - Objects not visible in navigator after ungrouping
Summary: Objects not visible in navigator after ungrouping
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3.7.2 release
Hardware: All All
: medium normal
Assignee: Jim Raykowski
URL:
Whiteboard: target:7.2.0 target:7.1.2
Keywords: bibisectRequest
Depends on:
Blocks:
 
Reported: 2021-02-25 10:19 UTC by Telesto
Modified: 2021-03-10 09:08 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (10.31 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-02-25 10:19 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-02-25 10:19:17 UTC
Description:
Objects not visible in navigator after ungrouping in DOCX

Steps to Reproduce:
1. Open the attached file
2. Select navigator in the sidebar -> Notice 1 object (fine)
3. Right Click the image & ungroup -> Navigator empty
4. Save & reload -> now it's oK

Actual Results:
Ungrouped elements not shown in navigator

Expected Results:
Should be visible


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 385808a2dff7300ec0120fdd5e8acfad8f86e50d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-02-25 10:19:29 UTC
Created attachment 170053 [details]
Example file
Comment 2 Telesto 2021-02-25 10:20:07 UTC
Also in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL
Comment 3 Telesto 2021-02-25 10:22:03 UTC
Also in
Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba

4.2. doesn't show anything


Adding bibisectrequest to figure out where the implementation error started
Comment 4 Telesto 2021-02-25 10:22:58 UTC
@Jim
Sidebar things & unique naming etc kind of your area.. So you might find this one interesting
Comment 5 Zivan Miljkov 2021-02-27 13:00:44 UTC
I succeeded easily to reproduced the bug with the attached file, on the following configuration:
Version: 7.0.0.0.alpha1 (x64)
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; 
Locale: en-US (en_US); UI: en-US
Calc: threaded

I would like to provide the set of step which I used (which are similar to the original scenario):
1. Open the attached file
2. Click on the image (left mouse click)
3. Open Navigator (select Navigator in the sidebar or using F5 keyboard shortcut) 
4. In the Navigator list, find Drawing objects item
5.a. In the Drawing objects item tree, there is the sub-item DrawObject1
6. Right mouse click on the image and choosing Ungroup option

Actual result:
-  In the Drawing objects item tree is empty - there are no sub-items (ungrouped elements).

Expected result:
- All ungrouped elements (in total 12) are listed in the Drawing objects item tree.

Additional information:
7. After document is Saved, Closed and opened again, all ungrouped elements are visible in the Drawing objects item tree.

The issue can be also reproduced in the following alternative scenarios:
- Alternative scenario 1 
    • After opening attached file, using Save as option, convert the file from .docx to .odt
    • Following steps 2 – 6 from the upper scenario, the actual result is the same
- Alternative scenario 2 
    • In the upper scenario, after step 5.a., one more step is added 5.b.
    • In step 5.b. rename DrawObject1 to some other name e.g. Bug140661
    • After performing the step 6. the actual result is the same.

The development team should take into account the resolvement of this issue as it will support different LibreOffice teams. This particular issue is important for the LibreOffice Design Team, as they stated: “The management of various objects is crucial for LibreOffice Draw, especially when a drawing or a diagram becomes complex with a lot of shapes and groups placed on different layers with an elaborated stack order.” (https://design.blog.documentfoundation.org/2016/07/31/how-the-navigator-may-support-object-handling-in-libreoffice-draw/).
Comment 6 Jim Raykowski 2021-03-01 02:57:09 UTC
Hi All, 

This also happens with using odt format.

Here is a patch that gives names to ungrouped shapes if they don't already have:

https://gerrit.libreoffice.org/c/core/+/111725
Comment 7 Jim Raykowski 2021-03-01 03:15:12 UTC
(In reply to Zivan Miljkov from comment #5)

> I would like to provide the set of step which I used (which are similar to
> the original scenario):
> 1. Open the attached file
> 2. Click on the image (left mouse click)
> 3. Open Navigator (select Navigator in the sidebar or using F5 keyboard
> shortcut) 
> 4. In the Navigator list, find Drawing objects item
> 5.a. In the Drawing objects item tree, there is the sub-item DrawObject1
> 6. Right mouse click on the image and choosing Ungroup option
> 

> Actual result:
>  -  In the Drawing objects item tree is empty - there are no sub-items (ungrouped elements).

Hi Zivan,

Please make a separate enhancement request for Ungroup to be included in the Navigator Drawing objects context menu. I'm not certain that it should be included there. Best to ask the design teams opinion before trying to do this.
Comment 8 Telesto 2021-03-01 07:58:38 UTC
(In reply to Jim Raykowski from comment #6)
> Hi All, 
> 
> This also happens with using odt format.
> 
> Here is a patch that gives names to ungrouped shapes if they don't already
> have:
> 
> https://gerrit.libreoffice.org/c/core/+/111725

That's quick! Many thanks! These kind of bug qualify under my 'get rid of' annoying bug which makes LibreOffice look bad program. 

Still trying to convince people to care more about this type of bugs/ usability glitches [and trim down on refactoring a bit). From developer perspective I get the whole refactoring, but user have a different perspective/ needs. It's all about finding proper balance. And I perceive it to be skewed towards Developers perspective.. This might what you get being open source. But surely an Achilles heel, IMHO

[Only sharing - unasked - my thoughts/ opinion :P. Not really your concern]
Comment 9 Commit Notification 2021-03-09 01:28:19 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1c3e170d56d3cad1e7729f839fa63f607b62e4e3

tdf#140661 Give shapes names when ungrouping if they don't already have

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2021-03-09 13:57:22 UTC
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 351b2382465087d18a3ad44509c2a3a66ca08aa6
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: 

@Jim Raykowski, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ?
Comment 11 Commit Notification 2021-03-09 21:17:42 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/b23a3518fd60be26607a1e8e50ddb821d63cc0b6

tdf#140661 Give shapes names when ungrouping if they don't already have

It will be available in 7.1.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2021-03-10 09:06:34 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9ad1da0086f6029a8a489988ae619cd4068aa275

tdf#140661: sw: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.