Bug 140705 - Some buttons has 'gtk-' before the text. Like 'gtk-cancel' instead of 'Cancel'
Summary: Some buttons has 'gtk-' before the text. Like 'gtk-cancel' instead of 'Cancel'
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-02-27 19:31 UTC by m_a_riosv
Modified: 2021-04-06 16:42 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshoot showing the issue. (44.23 KB, image/png)
2021-02-27 19:33 UTC, m_a_riosv
Details
Screenshot showing the issue (126.79 KB, image/png)
2021-03-05 10:14 UTC, m_a_riosv
Details
Screenshot showing the issue (36.16 KB, image/png)
2021-03-26 18:36 UTC, m_a_riosv
Details
Screenshoot showing the issue. (160.20 KB, image/png)
2021-04-03 23:42 UTC, m_a_riosv
Details
aboutdialog.ui (21.96 KB, application/x-gtk-builder)
2021-04-04 22:19 UTC, m_a_riosv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description m_a_riosv 2021-02-27 19:31:30 UTC
Some buttons has 'gtk-' before the text. Like 'gtk-cancel' instead of 'Cancel'

No issue with 
Version: 7.0.5.0.0+ (x64)
Build ID: e29387a749edb1bf39ca2b558099964da42b3a4b
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); Interfaz: es-ES Calc: CL

I see it with (clean profile)
Version: 7.1.2.0.0+ (x64) / LibreOffice Community
Build ID: 8885bf8f8665286ae1df30d987790e5680f2bb36
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES Calc: CL

And seems solved with
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c5b911b23f45ba86100c2eadc747b27c8744a96d
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 1 m_a_riosv 2021-02-27 19:33:35 UTC
Created attachment 170121 [details]
Screenshoot showing the issue.
Comment 2 Ming Hua 2021-02-28 07:47:31 UTC
Can not reproduce with 7.1.0 release:
Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: es-ES
Calc: threaded
The buttons are labelled "_Aceptar" and "_Cancelar".

There are changes in master (7.2) branch that touched these buttons, but they shouldn't affect 7-1 branch.  Will investigate further.
Comment 3 Ming Hua 2021-03-01 08:21:27 UTC
(In reply to Ming Hua from comment #2)
> Will investigate further.
Still not reproducible with 7.1.1 RC2:
Version: 7.1.1.2 (x64) / LibreOffice Community
Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: zh-CN (zh_CN); UI: es-ES
Calc: threaded
Comment 4 Xisco Faulí 2021-03-01 12:17:47 UTC Comment hidden (obsolete)
Comment 5 Xisco Faulí 2021-03-01 12:18:26 UTC
Not reproducible in

Version: 7.1.0.3 (x86) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded
Comment 6 m_a_riosv 2021-03-03 01:13:11 UTC
Still
Version: 7.1.2.0.0+ (x64) / LibreOffice Community
Build ID: 662649d953c1f0f461d8df019731bb8854b5922b
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: threaded
Comment 7 m_a_riosv 2021-03-05 10:12:14 UTC
Still with a clean profile
Version: 7.1.2.0.0+ (x64) / LibreOffice Community
Build ID: fed3ed5828eda88f82d97e95b34dfdd1ca0c9dec
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: threaded

Not with:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8e49505fa7352023c252bf794ae84c9082d7264e
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: threaded
Comment 8 m_a_riosv 2021-03-05 10:14:36 UTC
Created attachment 170232 [details]
Screenshot showing the issue
Comment 9 Buovjaga 2021-03-26 17:43:47 UTC
Not reproduced

Version: 7.1.2.1 (x64) / LibreOffice Community
Build ID: 094b4116e8de6d2085e9b65d26912d6eac4c74a9
CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: fi-FI (fi_FI); UI: fi-FI
Calc: threaded
Comment 10 m_a_riosv 2021-03-26 18:36:31 UTC
Created attachment 170771 [details]
Screenshot showing the issue

Version: 7.1.3.0.0+ (x64) / LibreOffice Community
Build ID: ea6193d64c5bed72bfb919b782434a0b3674c525
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: threaded
Comment 11 m_a_riosv 2021-04-03 23:42:20 UTC
Created attachment 170943 [details]
Screenshoot showing the issue.

Clean profile
Version: 7.1.3.0.0+ (x64) / LibreOffice Community
Build ID: 436573acb76714ae9b0ccb8e664911b9696269f4
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES Calc: CL
Comment 12 Caolán McNamara 2021-04-04 14:11:27 UTC
I can't reproduce this in my 7-1 linux gen version

cui/uiconfig/ui/aboutdialog.ui has...

<object class="GtkButton" id="btnClose">
  <property name="label">gtk-close</property>
  <property name="visible">True</property>
  <property name="can-focus">True</property>
  <property name="receives-default">True</property>
  <property name="use-underline">True</property>
  <property name="use-stock">True</property>
</object>

In 7.1, because of "use-stock", I expect vcl/source/window/builder.cxx:1301 extractStock to return true, and bLegacy to be false, and thus 

xWindow = VclPtr<PushButton>::Create(pParent, nBits);
xWindow->SetText(getStockText(sType));

to be called where getStockText is supposed to replace gtk-close with VclResId(SV_BUTTONTEXT_CLOSE)

if getStockText was called at all, failure would result in an empty string, not an unchanged string. The button is created so extractStockAndBuildPushButton must be called, so I can only surmise that extractStock returns false for some unknown reason and line 1323, xWindow = VclPtr<PushButton>::Create(pParent, nBits) is called leaving the label of gtk-close unconverted.

maybe m.a.riosv can attach the aboutdialog.ui file from their share/config/soffice.cfg/cui/ui directory to confirm it has the exected "use-stock" property for that btnClose dialog. If anyone with a debugging build can reproduce then putting a breakpoint in extractStockAndBuildPushButton is the place to start
Comment 13 m_a_riosv 2021-04-04 22:19:38 UTC
Created attachment 170954 [details]
aboutdialog.ui

Share the file, thanks for care.
Comment 14 m_a_riosv 2021-04-04 23:03:58 UTC
I do the installation with SIGUI, on the folder C:\Users\xxxx\Downloads\LibreOffice 7.1.64.
Deleting 'program' folder and reinstalling seems to solve the issue.

Maybe SIGUI or install program doesn't overwrite old files with a new installation.

And being a strange issue, doesn't merit further investigation.
Comment 15 Caolán McNamara 2021-04-05 15:16:19 UTC
FWIW that aboutdialog.ui is identical to the one I have in 7.1 so whatever the problem is its not due to e.g. a different aboutdialog.ui in the install