Created attachment 170145 [details] Example file from Writer Attached file contains about 12 thousand words of Lorem ipsum on 21 pages. Change tracking is enabled. When selecting Format – Text – Capitalize Every Word the operation takes about 15 seconds on my machine, and after that rejecting all changes takes about 45 seconds. Without change tracking enabled it is fast: about 1 second. Steps to reproduce: 1. Open attached file 2. Ctrl-A 3. Format – Text – Capitalize Every Word 4. Edit – Track Changes – Reject All Actual results: (in step 3) Creating ~12 thousand tracked changes is rather slow. With only 2 pages and 1000 words it took only ~1 second, and with 4 pages it started to be noticeably janky. (in step 4) Rejecting all those changes is about three times slower. Expected results: Making redline creation/rejection fast even in such an extreme (or even accidental) use case. For the short term, not making redlines at all for this operation (above some fixed amount of words) might work as well. LibreOffice details: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e60bebd4c5257b0f592d27c74399de1498ac725b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-GB Calc: CL Additional Information: Bibisected using bibisect-win64-7.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2d3c77e9b10f20091ef338e262ba7756eb280ce9 Author: László Németh <nemeth@numbertext.org> Date: Thu Nov 5 10:17:03 2020 +0100 tdf#109266 sw change tracking: track transliteration Format->Text->UPPERCASE, tOGGLE cASE etc. weren't supported by change tracking. Before this the operation was not change tracked.
Balazs Santha committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e463d239555d3a4dc61797eeb8c638b6442112a3 tdf#140731: sw transliteration: avoid too many redlines It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Commit description: tdf#140731: sw transliteration: avoid too many redlines As a workaround for the performance regression from commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9 (tdf#109266 sw change tracking: track transliteration), switch off redlining to avoid ~freezing, if a single transliteration could result too many (>~500) redlines. A single transliteration creates n redlines for n paragraphs of the selected text, except in the case of transliterating to title case, where it creates n redlines for n words. It's very easy to freeze Writer, because Writer's slowing down with n redlines is described by an O(n²) (quadratic) time complexity. Eg. in an experiment, title casing ~660 words was 6 sec, but ~3000 words was 85 sec, regarding to creating 660 vs 3000 redlines. Note: this is a partial revert of commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9, if the selection contains more than 500 paragraphs (or in the case transliterating to title case, ~500 words).
Balazs Santha committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e9f9e2315ba5a4f10ac0d3a6a6a6cca711d49b6f sw: test fix of tdf#140731 (freezing with track changes) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.