Bug 140800 - Improve dialog for saving/loading Outline Formats in Tools > Chapter Numbering (see comment 8)
Summary: Improve dialog for saving/loading Outline Formats in Tools > Chapter Numberin...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: Heading-Numbering-Dialog
  Show dependency treegraph
Reported: 2021-03-04 15:56 UTC by sdc.blanco
Modified: 2021-03-10 10:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Backtrace from master (36.90 KB, text/x-log)
2021-03-09 12:07 UTC, Heiko Tietze

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2021-03-04 15:56:50 UTC
1.  Start with no chapter.cfg in {user profile}/config  [just to be pure]
2.  Tools > Chapter Numbering
3.  Use the dialog box to make some modifications (e.g., add numbering to
    first three levels)
4.  Load/Save > Save As, give a name, and Ok.
5.  Load/Save > Untitled 9

Actual Result:  The just-saved profile remains loaded (as seen in preview and looking at the levels).

Expected result:  The dialog is "reset" to default, because nothing was saved for 'Untitled 9.'

Enhancement request: a better design is needed here.  
   - the "Reset" button does not reset anything,even just changing the Number
     control and then immediately using Reset does not reset.  Maybe "Reset"
     should be removed from this dialog? 
   - maybe a "Default" or "reset" entry should be available in Load/Save dropdown.
   - maybe a popup warning "Nothing saved for Untitled 9" should appear
     for all names in Load/save that do not actually have entries in chapter.cfg.
Comment 1 sdc.blanco 2021-03-04 16:18:10 UTC
> Actual Result:  The just-saved profile remains loaded (as seen in preview
> and looking at the levels).
Slight correction/elaboration:

Actual result: Loading an empty entry loads the first "non-empty" entry.

That is, if a numbering format was saved where Untitled 1 appeared, then this entry is always loaded, if an empty entry is selected.
Comment 2 Heiko Tietze 2021-03-09 11:54:17 UTC
Save As puts the new item at the end of the list and apparently "Untiled " means empty. The question is what happens when all slots are filled- I'd assume you either cannot save anymore until one item is removed or you overwrite the first. But in fact the application crashes for me.

The approach with items in a menu is clearly not working. My take is to use a true list with Add/Remove buttons, as recommended everywhere else.
Comment 3 Heiko Tietze 2021-03-09 12:07:01 UTC Comment hidden (off-topic)
Comment 4 sdc.blanco 2021-03-09 12:29:08 UTC Comment hidden (off-topic)
Comment 5 Heiko Tietze 2021-03-09 14:53:14 UTC Comment hidden (off-topic)
Comment 6 sdc.blanco 2021-03-09 15:30:38 UTC Comment hidden (off-topic)
Comment 7 Heiko Tietze 2021-03-09 15:32:30 UTC Comment hidden (off-topic)
Comment 8 sdc.blanco 2021-03-09 16:43:19 UTC
New Description.

1. Tools > Chapter Numbering is where it is necessary to add numbering/bullets (and format their layout) for Heading 1-10.

2.  At present, the Load/Save dialog offers the possibility to "save" a design (stored in {user profile}/config/chapter.cfg), which can then be loaded into other documents.

3.  As noted in comment 2, maybe a new approach is needed.

4.  Meanwhile, where are problems with current design that a new design should address.

A.  There needs to be a way to "reset" the dialog (i.e., values for numbering and position at different levels) to "null/initial state"), or maybe just a "New" command to get a "clean sheet" from which to start.

B. In current design, it is possible to load an "empty" entry, but maybe the dropdown list should only show actually existing formats, so that you do not have to guess if the entry has been configured or not.

C.  There are some experiences (also by Timur) that "Position" information is not always saved (but have not found reliable STR) or maybe there is a problem with how Loading is working in relation to position (that makes it look like information is lost).  

In short, from user PoV (independently of how implemented): 
- "Save as" should save numbering and position information for all levels.
- Loading a "saved entry" should completely update the loaded values for numbering and position for all levels, according to the saved entry. 
- Preview should be updated when loading a saved entry to correspond to the saved entry.
Comment 9 Heiko Tietze 2021-03-10 08:34:55 UTC
See bug 120905 what I have in mind.