Bug 140839 - Many images in ToTD looks cropped or blurry
Summary: Many images in ToTD looks cropped or blurry
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2021-03-06 11:15 UTC by Rizal Muttaqin
Modified: 2021-04-05 06:52 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Some screenshots of bad image in ToTD (135.92 KB, application/zip)
2021-03-06 11:15 UTC, Rizal Muttaqin
Details
Screenshot with scaling applied (230.29 KB, image/png)
2021-03-08 08:03 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2021-03-06 11:15:50 UTC
Created attachment 170267 [details]
Some screenshots of bad image in ToTD

Step to reproduce:

1. Open Tip of The Day (Help > Show tip of the day)
2. See some tips: 6, 8, 10, 13, 14, 15, they have cropped and misplaced images


Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 1e092b6bde40d5e69c1ef92fca201896ff75bf18
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-03-03_19:58:35
Calc: threaded
Comment 1 Heiko Tietze 2021-03-06 11:18:28 UTC
We can either scale the image (ends up in bad quality), crop (makes it unreadable), make the dialog larger (might lead to bad design; thought it was implemented like this), or change the images to comply (unsafe). Opinions?
Comment 2 andreas_k 2021-03-06 11:55:31 UTC
What's the needed size, so I can fit the images to the correct size.
Comment 3 Mike Kaganski 2021-03-06 12:48:47 UTC
Looks like the images are made on a HiDPI system. They may be either created on a Lo-DPI system (which would require upscaling on Hi_DPI systems -> blur), or have several image versions for different scaling (100%-150%-175%-200% -> maintenance burden)...
Comment 4 S.Zosgornik 2021-03-07 11:53:36 UTC
I don't know the render capabilities but how about using a very large image and downscale it to the giving resolution?

Having full vector graphics support should be the right solution but I don't know the current state.
Comment 5 Heiko Tietze 2021-03-08 07:43:59 UTC
Image size is 100x120, and it's not scaled but cropped. The dialog looks totally weird with larger images.

Scaling is possible (patch in preparation) but not for animated graphics. I would prefer smaller and fix-sized images.
Comment 6 Heiko Tietze 2021-03-08 08:03:27 UTC
Created attachment 170330 [details]
Screenshot with scaling applied

Made on a mac with a 2560×1600 resolution.
Comment 7 andreas_k 2021-03-08 08:23:47 UTC
(In reply to Heiko Tietze from comment #6)
> Created attachment 170330 [details]
> Screenshot with scaling applied
> 
> Made on a mac with a 2560×1600 resolution.

So hidpi is an issue.

the previews were drawn with LibreOffice Draw. I can offer (maybe) svg output, or high scaled thumbs (4x 100 x 120 px). What would be prefered?
Comment 8 Heiko Tietze 2021-03-08 08:31:50 UTC
(In reply to andreas_k from comment #7)
> So hidpi is an issue.

No, it's not- the screenshot should show it. Before the patch [1] images were cropped, now they are scaled (unless it contains animation, which is only true for the marching ants).

Scaling blurs the images and at ~50% of the intended size it's also hard to read. So it would be nice to have all preview images in 100x120px.

[1] https://gerrit.libreoffice.org/c/core/+/112152
Comment 9 Commit Notification 2021-03-10 09:27:20 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7abfb02bda53ed71cdca335fa99490992fa7092b

tdf#140839 - Scale TotD image

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-03-30 14:43:56 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d5533669000078bef46f353c99f4fda2c8476a39

tdf#140839 - TotD image size

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-04-05 06:52:58 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/21d69f8fd4261bec73e209fbf17b11348c70946f

tdf#140839 all ToTD images use 150x150px size

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.