Bug 141000 - Icon pack name should support multiple words
Summary: Icon pack name should support multiple words
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Zain Iftikhar
URL:
Whiteboard: target:7.4.0 target:7.3.4
Keywords: difficultyBeginner, easyHack, skillCpp, topicDesign
Depends on:
Blocks:
 
Reported: 2021-03-13 16:12 UTC by Paul Kepinski
Modified: 2022-05-01 08:46 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Icon pack wrong name (52.14 KB, image/jpeg)
2021-03-13 16:16 UTC, Paul Kepinski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Kepinski 2021-03-13 16:12:49 UTC
Description:
When installing and icon pack like the Yaru MATE one (https://github.com/ubuntu/libreoffice-style-yaru-fullcolor) you can see that Libreoffice only support one word for pack name. Using multiple words, display an underscore instead of a white space.

Steps to Reproduce:
1. Install an icon pack, like Yaru MATE, with more than one word long name.
2. Open the options (Tools → Options) then go to LibreOffice → View → Icon style 
3. See the name problem

Actual Results:
It display Yaru_mate.

Expected Results:
It should display Yaru mate.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.3.1
Build ID: 00(Build:1)
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Ubuntu package version: 1:7.0.3-0ubuntu0.20.10.1
Calc: threaded
Comment 1 Paul Kepinski 2021-03-13 16:16:06 UTC
Created attachment 170456 [details]
Icon pack wrong name
Comment 2 Heiko Tietze 2022-03-21 10:53:09 UTC
In IconThemeInfo::ThemeIdToDisplayName() we have a conversion table for theme ID to name. Would suggest to always convert underscores into spaces and to use title style capitalization. Meaning karasa_jaga would become Karasa Jaga and yaru_mate Yaru Mate. Don't see a chance to use all uppercase for MATE.
Comment 3 Paul Kepinski 2022-03-21 11:41:48 UTC
Not having uppercase for yaru-mate is not very important.
The main problem was really those underscore.

I am glad to hear that this will be fixed!
Comment 4 Commit Notification 2022-04-21 16:53:15 UTC
Zain Iftikhar committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/02b740a7a047052e60274b8649f3624267eb079f

tdf#141000 replacing underscores with spaces of multi words icon pack name

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Heiko Tietze 2022-04-22 07:40:09 UTC
The patch changes every underscore into a space. But it converts only the very first character into uppercase so we get "Karasa jaga". Not sure how MATE is written, the uppercase letters will remain.
Comment 6 Paul Kepinski 2022-04-22 11:14:17 UTC
Very nice!
Thanks very much for the patch.

Is there any chance to get a backport to LO 7.3?
Ubuntu 22.04 LTS use this version, and it will be there for more than 2 years.
Comment 7 Commit Notification 2022-05-01 08:04:46 UTC
Zain Iftikhar committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/405cbcdcaac4ebb9e68240ef8a94821f9f21f6a8

tdf#141000 replacing underscores with spaces of multi words icon pack name

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Adolfo Jayme Barrientos 2022-05-01 08:06:41 UTC
Perfect is the enemy of good, so I’ve merged a backport.
Comment 9 Paul Kepinski 2022-05-01 08:46:12 UTC
Thanks very much! :)