Bug 141186 - In Print dialog <alt>+G gives focus to Orientation too
Summary: In Print dialog <alt>+G gives focus to Orientation too
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All Linux (All)
: medium trivial
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-03-22 22:56 UTC by Terrence Enger
Modified: 2022-06-20 09:03 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
tail of terminal output, bibisect linux-7.2 (2.79 KB, text/plain)
2021-03-22 22:59 UTC, Terrence Enger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Terrence Enger 2021-03-22 22:56:57 UTC
component : Writer
summary   ; In Print dialog <alt>+G gives focus to Orientation too
severity  : trivial
body
----
In the Print dialog of Writer, "<alt>+G" behaves in surprising ways:

(*) It alternates focus between Orientation and Pages; I expect focus
    to go directly to Pages.

(*) When it gives focus to Pages, it fails to select that radio
    button.

In more detail:

STR
---
(1) Open a Writer document of moderate length and move to page 2.
    Status bar at bottom ow the Writer window displays "Page 2 of ...".

(2) Type "<alt>+F P".  Program displays Print dialog and tab General;
    in section "Range and copies", radio button "All Pages" is
    selected.

(3) Press "<alt>".  Program underscores "g" in "Pages" and the first
    "t" in "Orientation".

(4) Type "<alt>+G".

    Expected : Program gives focus to control Pages.

    Observed : Program gives focus to control Orientation; with
               SAL_USE_VCLPLUGIN=gtk3, there is no immediately visible
               indication of this, but <down> changes the selected
               orientation from Automatic to Landscape.

(5) Type "<alt>+G".  Program gives focus to control Pages; the word is
    outlined and page number 2 is displayed in the input area.

    Expected : Radio button <Pages> selected.

    Observed : Radio button <Pages> is not selected; typing "<space>"
               selects the radio button and moves the caret into the
               input area.


I made these observations on a local build of commit feb6fd1f
(2021-03-17), configured --enable-dbgutil, built and running on
debian-buster with xfce desktop.


I am setting severity trivial.
Comment 1 Terrence Enger 2021-03-22 22:59:23 UTC
Created attachment 170641 [details]
tail of terminal output, bibisect linux-7.2

From bibisect repository linux-7.2 running on debian-buster with xfce
desktop:

          commit    s-h       date
          --------  --------  -------------------
    good  8bdb4e70  15eb9305  2021-01-15 11:42:32
    bad   5ed755da  9100d70e  2021-01-15 11:43:22

The commit message is:

    Author: Caolán McNamara <caolanm@redhat.com>
    Date:   Mon Jan 11 16:17:32 2021 +0000

        replace stock button labels
    
        Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

I am adding keywords regression, bibisected, bisected.
Comment 2 Xisco Faulí 2021-04-01 09:00:21 UTC
I can't reproduce it in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: c088d26578d1be352efa49bd164a8217627648de
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Terrence, could you please try again with a recent daily build ?
Comment 3 Terrence Enger 2021-04-01 16:02:54 UTC
Whoops.  I should have said that I was using (by default) VCL gtk3.

I am leaving status NEEDINFO.
Comment 4 QA Administrators 2021-04-02 03:48:10 UTC Comment hidden (obsolete)
Comment 5 Terrence Enger 2021-04-02 14:23:50 UTC
I am setting status NEEDINFO, because I have not really answered
Xisco' comment 2.
Comment 6 QA Administrators 2021-04-03 03:47:24 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2021-10-04 03:46:26 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2021-11-04 04:10:31 UTC Comment hidden (obsolete)
Comment 9 Terrence Enger 2021-11-11 16:55:51 UTC
I still see the problem in a local build of commit 631aa911
(2021-11-09), built and running on debian-buster and in s-h a14b783b
(2021-11-09) in linux-64-7.3 bibisect repository.

I am setting status UNCONFIRMED.
Comment 10 Jean-Baptiste Faure 2022-05-14 15:15:24 UTC
In current master, I do not reproduce this. Alt+G alternates between "Pages" under "Range and Copies" and "Pages per sheet" under More under "Page Layout". For both, alt underscores the g of page.
Of course, the problem depends on localization. For French UI, the problem does not occur because "Pages per sheet" is translated as "Pages par feuille" with the f underscored.

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: c63b86501828d35c3a80aa5be2d70f992b4f1b23
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Ubuntu_20.04_x86-64
Calc: threaded

Best regards. JBF
Comment 11 raal 2022-05-14 19:48:52 UTC
I can confirm with Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 75f7e057039aaa49558e22d18cad651d11589da9
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 12 raal 2022-05-14 19:50:10 UTC
(In reply to Terrence Enger from comment #1)
> Created attachment 170641 [details]
> tail of terminal output, bibisect linux-7.2
> 
> From bibisect repository linux-7.2 running on debian-buster with xfce
> desktop:
> 
>           commit    s-h       date
>           --------  --------  -------------------
>     good  8bdb4e70  15eb9305  2021-01-15 11:42:32
>     bad   5ed755da  9100d70e  2021-01-15 11:43:22
> 
> The commit message is:
> 
>     Author: Caolán McNamara <caolanm@redhat.com>
>     Date:   Mon Jan 11 16:17:32 2021 +0000
> 
>         replace stock button labels
>     
>         Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a
>         Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197
>         Tested-by: Jenkins
>         Reviewed-by: Caolán McNamara <caolanm@redhat.com>
> 
> I am adding keywords regression, bibisected, bisected.

Adding cc to: Caolán McNamara
Comment 13 Caolán McNamara 2022-05-14 21:07:36 UTC
I think the 2nd _g is hidden inside that page layout expander so the focus is jumping to the invisible "pages per sheet" and pressing down is then selecting "brochure" which has side effect of changing the orientation.
Comment 14 Caolán McNamara 2022-05-18 09:57:56 UTC
if I expand and then collapse the "more" of page layout then gtk doesn't pay attention to the collapsed "Pages per sheet" widget
Comment 15 Caolán McNamara 2022-05-18 15:27:00 UTC
I see a route out of this problem now.
Comment 16 Commit Notification 2022-05-19 07:53:33 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/30ed714415eb6a5f200f893afa34b9d274ae8d1f

tdf#141186 ensure child of collapsed expander is not mapped

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Terrence Enger 2022-05-25 20:42:43 UTC
In a local build of commit 30ed7144, built and running on
debian-buster, I see the problem fixed.

Thank you, Caolán.  I am setting status VERIFIED FIXED.
Comment 18 Commit Notification 2022-06-20 09:03:27 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/6d9bcfabc727e97536364f6f0bda12fc85876ac2

tdf#141186 ensure child of collapsed expander is not mapped

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.