Bug 141197 - Buttons in LO startcenter are not available through accessibility
Summary: Buttons in LO startcenter are not available through accessibility
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2021-03-23 13:13 UTC by mkrajnak
Modified: 2021-04-13 12:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mkrajnak 2021-03-23 13:13:10 UTC
Description:
Exploring LO StartCenter through ATSPI Browser/Accerrciser shows that buttons shown in StartCenter is not available through accessibility.

The upper menu with File, Tools, About is shown correctly.
Other buttons like Open File, Remote Files ... Extensions are not shown.


Steps to Reproduce:
1.Open Libreoffice StartCentre from terminal
2.Open accessibility browser


Actual Results:
Above mentioned buttons are not accessible

Expected Results:
Above mentioned buttons should be accessible


Reproducible: Always


User Profile Reset: No



Additional Info:
$ rpm -q libreoffice-core
libreoffice-core-7.1.0.3-3.el9.x86_64
$ soffice 

** (soffice:19098): CRITICAL **: 13:44:40.365: AtkObject* atk_object_wrapper_ref(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, bool): assertion 'bool(rxAccessible)' failed

** (soffice:19098): CRITICAL **: 13:44:50.392: AtkObject* atk_object_wrapper_ref(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, bool): assertion 'bool(rxAccessible)' failed

(soffice:19098): GLib-GObject-WARNING **: 13:59:53.341: ../gobject/gsignal.c:2732: instance '0x55a78a3b8cc0' has no handler with id '1129'
Comment 1 Caolán McNamara 2021-03-23 14:49:06 UTC
I think the:

** (soffice:19098): CRITICAL **: 13:44:40.365: AtkObject* atk_object_wrapper_ref(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, bool): assertion 'bool(rxAccessible)' failed

warning is since 

commit cbc18cc904c652a936c4b68fba4d975bd89b5abd
Author: Thomas Viehmann <tv@beamnet.de>
Date:   Mon Nov 23 21:03:28 2020 +0100

    tdf#138425 vcl/gtk activate main menu in UpdateFull
Comment 2 Commit Notification 2021-03-24 09:14:24 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2beb3922391ae1a6f1d26128d82c0e34cb963af3

Related: tdf#141197 critical a11y warning

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Caolán McNamara 2021-03-24 11:43:23 UTC
I have high hopes for https://gerrit.libreoffice.org/c/core/+/113033
I'll provide fedora rawhide/F34 updates to see if it is sufficient for what you need
Comment 4 Commit Notification 2021-03-24 19:38:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/305c6fee0be4db38023d9ca5f7915e443e0bc1fc

tdf#141197 if we have a sysobj child then include that in the atk hierarchy

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2021-03-25 10:36:06 UTC
fixed in main
Comment 6 Commit Notification 2021-03-30 09:18:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/b9de0b5d94a155ccd43e28841064e7c1b1f9ab1d

Related: tdf#141197 critical a11y warning

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-04-06 10:45:04 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/4b2dc7863a532bdac4db59f9e0cce126f80207d3

tdf#141197 if we have a sysobj child then include that in the atk hierarchy

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Jean-Baptiste Faure 2021-04-06 19:23:27 UTC
Hi Caolán,

I am sorry but this commit make failing the build of LO 7.1.3 under Ubuntu 18.04 x86-04. If I revert the commit build is successful.

The error is:

/home/libo/7/workdir/CxxObject/vcl/unx/gtk3/a11y/gtk3atkwrapper.o : Dans la fonction « atk_object_wrapper_new » :
gtk3atkwrapper.cxx:(.text+0x1197) : référence indéfinie vers « UnoWrapperBase::GetUnoWrapper(bool) »

In English, something like:

/home/libo/7/workdir/CxxObject/vcl/unx/gtk3/a11y/gtk3atkwrapper.o : In the function « atk_object_wrapper_new » :
gtk3atkwrapper.cxx:(.text+0x1197) : undefined reference to « UnoWrapperBase::GetUnoWrapper(bool) »

Best regards. JBF
Comment 9 Andras Timar 2021-04-06 21:56:03 UTC
(In reply to Jean-Baptiste Faure from comment #8)
> Hi Caolán,
> 
> I am sorry but this commit make failing the build of LO 7.1.3 under Ubuntu
> 18.04 x86-04. If I revert the commit build is successful.
> 
> The error is:
> 
> /home/libo/7/workdir/CxxObject/vcl/unx/gtk3/a11y/gtk3atkwrapper.o : Dans la
> fonction « atk_object_wrapper_new » :
> gtk3atkwrapper.cxx:(.text+0x1197) : référence indéfinie vers «
> UnoWrapperBase::GetUnoWrapper(bool) »
> 
> In English, something like:
> 
> /home/libo/7/workdir/CxxObject/vcl/unx/gtk3/a11y/gtk3atkwrapper.o : In the
> function « atk_object_wrapper_new » :
> gtk3atkwrapper.cxx:(.text+0x1197) : undefined reference to «
> UnoWrapperBase::GetUnoWrapper(bool) »
> 
> Best regards. JBF
 3d844a131d7d2d2c82d865d17ad7657c7e8a185c is missing
Comment 10 Caolán McNamara 2021-04-07 08:08:03 UTC
The above commit is in 7-1 series now.
Comment 11 Jean-Baptiste Faure 2021-04-07 11:09:11 UTC
(In reply to Caolán McNamara from comment #10)
> The above commit is in 7-1 series now.

Thank you very much, LO 7.1 now builds successfully.

Best regards. JBF
Comment 12 mkrajnak 2021-04-13 12:17:44 UTC
I can confirm it works with libreofficedev7.1-7.1.3.0.0-1.x86_64.rpm, thanks a lot Caolan !