Bug 141215 - EDITING: Transposed notes/comments not copied in certain cases
Summary: EDITING: Transposed notes/comments not copied in certain cases
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: All All
: medium normal
Assignee: Roland Kurmann
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-23 20:47 UTC by Roland Kurmann
Modified: 2021-05-21 18:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Simple table (7.70 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-03-23 20:52 UTC, Roland Kurmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Kurmann 2021-03-23 20:47:57 UTC
Description:
If the first row is not set on the second column, then this transposed row does not have any copied notes.
If you add note, then all the other notes are copied as well.

The transpose column notes algorithm of ScTable::TransposeColNotes() is not correct.

Steps to Reproduce:
1. Open attached file
2. Select A1:B3
3. Go to cell A6
4. Right click > Paste Special > Paste Special...
5. Press on the transpose button in the Paste Special dialog

Actual Results:
The data is transposed.
The row 6 has the notes of column A.
The row 7 is missing all notes.

Expected Results:
The data is transposed.
The row 6 has the notes of column A.
The row 7 has the two notes of column B (i.e. B2 and B3).


Reproducible: Always


User Profile Reset: No



Additional Info:
I've found this bug while fixing #107348.

Related to fdo#68381

Version: 7.0.4.2
Build ID: 00(Build:2)
CPU threads: 4; OS: Linux 5.3; UI render: GL; VCL: kf5
Locale: de-CH (en_US.UTF-8); UI: de-DE
Calc: threaded

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 9dfaf0fa1977f70341e4b9add2ecd2afb35bf1f2
CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Roland Kurmann 2021-03-23 20:52:34 UTC
Created attachment 170677 [details]
Simple table

I'll fix this bug together with #107348.

I've just documented this bug for QA.
Comment 2 m_a_riosv 2021-03-23 22:19:13 UTC
Reproducible
Version: 7.0.5.2 (x64)
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 78c33a4c3d1633b97049874305b3b49b820395a2
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 3 Julien Nabet 2021-03-24 19:18:35 UTC
Let's put this one to ASSIGNED since you assigned yourself.
Comment 4 Roland Kurmann 2021-04-22 05:52:19 UTC
I've submitted a patch to gerrit: https://gerrit.libreoffice.org/c/core/+/114450

Waiting for review
Comment 5 Commit Notification 2021-04-22 13:12:30 UTC
scito committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6491c205acb3c166d93ef6a41199d344e21d98ac

tdf#107348 tdf#45958 tdf#141215 tdf#141683 fix filtered/transpose paste

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 BogdanB 2021-05-21 18:02:02 UTC
It's ok now.

Verified in
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: b238522ca121ca8f863fe4d3394ade088a65ad01
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded