Bug 141282 - .uno:DecrementSubLevels ("Demote One Level with Subpoints") has the wrong icon
Summary: .uno:DecrementSubLevels ("Demote One Level with Subpoints") has the wrong icon
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords:
Depends on:
Blocks: Bullet-Number-Outline-Lists Icon-Theme-Sukapura
  Show dependency treegraph
 
Reported: 2021-03-27 10:05 UTC by sdc.blanco
Modified: 2021-03-30 14:40 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Do you mean Sukapura icon? Other icon theme has no issue (85.41 KB, image/png)
2021-03-27 11:14 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2021-03-27 10:05:07 UTC
Format > Lists > Demote One Level with Subpoints

The icon shown for .uno:DecrementSubLevels is actually the icon for .uno:MoveDownSubItems ("Move Down with Subpoints") -- which is also shown in the same menu.

Probably the icon should be (something like) lc_decrementsublevels.png instead of lc_movedownsubitems.png
Comment 1 Rizal Muttaqin 2021-03-27 10:26:54 UTC
(In reply to sdc.blanco from comment #0)
> Format > Lists > Demote One Level with Subpoints
> 
> The icon shown for .uno:DecrementSubLevels is actually the icon for
> .uno:MoveDownSubItems ("Move Down with Subpoints") -- which is also shown in
> the same menu.
> 
> Probably the icon should be (something like) lc_decrementsublevels.png
> instead of lc_movedownsubitems.png

What icon theme do you mean? set to NEEDINFO
Comment 2 sdc.blanco 2021-03-27 10:34:53 UTC
(In reply to Rizal Muttaqin from comment #1)
> What icon theme do you mean? set to NEEDINFO
No problem with the icons themselves.
Problem with the icon assigned to .uno:DecrementSubLevels
Comment 3 Rizal Muttaqin 2021-03-27 10:51:24 UTC
(In reply to sdc.blanco from comment #2)
> (In reply to Rizal Muttaqin from comment #1)
> > What icon theme do you mean? set to NEEDINFO
> No problem with the icons themselves.
> Problem with the icon assigned to .uno:DecrementSubLevels

Chance that every icon theme has different issue/appearance. Do you mean Colibre icon?
Comment 4 Rizal Muttaqin 2021-03-27 10:56:03 UTC
(In reply to Rizal Muttaqin from comment #3)
> Do you mean Colibre icon?

Ah sorry Colibre use different icon. Don't know which icon theme do you means. Any screenshot?
Comment 5 Rizal Muttaqin 2021-03-27 11:14:04 UTC
Created attachment 170781 [details]
Do you mean Sukapura icon? Other icon theme has no issue
Comment 6 sdc.blanco 2021-03-27 11:15:30 UTC
(In reply to Rizal Muttaqin from comment #4)
> Ah sorry Colibre use different icon. Don't know which icon theme do you
> means. Any screenshot?
Apologies.  I did not realize that icon theme could make a difference here.

I have a screenshot now, but maybe it is enough if I just inform: Sukapura

(which I see you also figured out while I was trying to send this reply (-: )
Comment 7 Commit Notification 2021-03-27 13:09:58 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2eb3c3ebfadc0927c0cdb2dad2c8f7716557ab3b

Sukapura: tdf#141282 fix wrong icon for Demote One Level with Subpoints

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-03-27 15:47:06 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1a833dd433f80fc61a41e34928bfde1e4070ed65

Sukapura: tdf#141282 fix wrong icon for Demote One Level with Subpoints

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 sdc.blanco 2021-03-30 09:16:26 UTC
Thanks Rizal. Icon pointing in the right direction now...

Verified with:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 35a06c67701eacb85591b61c948233a4f0ad238b
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-US (en_DK); UI: en-US
Calc: CL
Comment 10 Rizal Muttaqin 2021-03-30 14:40:50 UTC
(In reply to sdc.blanco from comment #9)
> Thanks Rizal. Icon pointing in the right direction now...
> 
> Verified with:
> 
> Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 35a06c67701eacb85591b61c948233a4f0ad238b
> CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (en_DK); UI: en-US
> Calc: CL

and big thanks for your report. I am glad to see someone who reported icon issue.