Bug 141528 - Linked OLE: Error when breaking linked OLE
Summary: Linked OLE: Error when breaking linked OLE
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Armin Le Grand
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords:
: 89292 (view as bug list)
Depends on:
Blocks: Files-Linked
  Show dependency treegraph
 
Reported: 2021-04-07 07:33 UTC by Armin Le Grand
Modified: 2023-05-25 10:43 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Armin Le Grand 2021-04-07 07:33:16 UTC
While fixing aspect (2) of tdf#130945 I stumbled upon 'break link' that also needs to be adapted. I thought I did something wrong in my adaptions, but it seems broken on current master, too:

- create calc testfile with some content (a), save, close
- create writer, insert/Object/Ole-Object...
- create from file, choose (a), activate 'link from file' -> ok
- edit/link to external files...
- break link -> yes, close dialog
- activate OLE, change something, deactivate
- close writer, do not save
-> calc testfile (a) is modified -> error
This should *not* happen, the embedded OLE should be modified from now on.

Even when you *save* the writer, close, reload it asks for *updating* the contained links -> breaking link to OLE *is* not working, link stays without being shown.

Also refer to https://bugs.documentfoundation.org/show_bug.cgi?id=130945#c5
Comment 1 Armin Le Grand 2021-04-07 07:34:14 UTC
Needed for continuing aspect (2) of tdf#130945, grepping...
Comment 2 Armin Le Grand 2021-04-07 09:19:44 UTC
Solution on gerrit, see https://gerrit.libreoffice.org/c/core/+/113722
Comment 3 Commit Notification 2021-04-07 12:41:06 UTC
Armin Le Grand (Allotropia) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2f665daa29dd5509b4ceb0461e76292e2262fa56

tdf#141528 ensure that reset of linked state is executed

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-04-08 17:50:49 UTC
Armin Le Grand (Allotropia) committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/b6928c98870ad9dfe261d870fc3411c4eda7902b

tdf#141528 ensure that reset of linked state is executed

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2023-05-25 10:41:29 UTC
*** Bug 89292 has been marked as a duplicate of this bug. ***