While fixing aspect (2) of tdf#130945 I stumbled upon the following error: Linked OLE gets modified independent from hosting document. In other words: When embedding a linked OLE, activating & changing it (also possible: activate & change size), deactivating, the OLE gets modified. This is not very intuitive from user's view and even not very logic when the hosting file (e.g. a new writer file) gets not saved itself. It would be much better to *synchronize* changes to the linked OLE to changes/svaing of the file/document the OLE is embedded to. Example: - new Writer - insert prepared calc OLE embedded - activate it, change someting - deactivate - close Writer document without saving it Result: prepared calc OLE is changed Expected result: prepared calc OLE is *not* changed -> A fix would need to couple saving of changed embedded OLEs to saving the hosing document Also refer to https://bugs.documentfoundation.org/show_bug.cgi?id=130945#c4
Needed for continuing aspect (2) of tdf#130945, grepping...
Good progress, following the path to hold the linked OLE as a cc in a temp file and sync it's save's to the hosting document's saves. This includes setup, copy back on save and handling in some other situations. Pretty far with 'other' situations, but want to do some more checks before getting serious with it...
Looks good, polishing. Most problematic was solving the offered 'break link' to linked OLEs (in dialog edit/links to external files...).
Armin Le Grand (Allotropia) committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4c66a2272d890eaa7a6d7429e5bfa7bdb1f7162 tdf#141529 sync linked OLE save(s) with hosting file save(s) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Armin Le Grand (Allotropia) committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/aeca771f8a8e4c77008e921eebcdb5784003e419 tdf#141529 sync linked OLE save(s) with hosting file save(s) It will be available in 7.1.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.