Bug 141703 - EDITING Tab key no longer moves to next cell in Impress table
Summary: EDITING Tab key no longer moves to next cell in Impress table
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: high normal
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-04-15 11:51 UTC by NISZ LibreOffice Team
Modified: 2021-04-26 08:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Impress (11.96 KB, application/vnd.oasis.opendocument.presentation)
2021-04-15 11:51 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-04-15 11:51:26 UTC
Created attachment 171218 [details]
Example file from Impress

Attached document contains a simple table on a slide.
Recently the Tab keys function changed from moving to the next cell to inserting a tabulator character, while Shift+Tab changed from moving to the previous cell to doing nothing.

Steps to reproduce:
    1. Open attached file
    2. Click into the first cell of the table
    3. Press Tab.

Actual results:
A tabulator character is inserted.

Expected results:
Cursor should move to the second cell. Only Ctrl+Tab moves to the second cell, and Shift+Tab does nothing.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 77419c6f3aba1fd5b1660795923c22a39bdb1bad
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: hu-HU
Calc: CL

Additional Information: 

Bibisected using bibisect-win64-7.2 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=67ad205404211a2ae17c430a17ede6e9d04d0b7e 

author	Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>	2021-03-03 07:47:43 +0100
committer	Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>	2021-03-15 12:47:34 +0100

tdf#139804 Focus form controls inside document with Alt-<Mnemonic>

Adding CC to: Samuel Mehrbrodt
Comment 1 Timur 2021-04-15 12:22:06 UTC
I consider this a bug. Tab to next cell and Shift to revert is known behavior and Mso does the same. 
Ctrl+Tab should make a tab. So in this bug should both be fixed.
Comment 2 V Stuart Foote 2021-04-15 16:01:36 UTC
Just checked a 7.1.3 nightly from 2021-04-14, the bisected commit was backported there already--needs to come out.

Version: 7.1.3.0.0+ (x64) / LibreOffice Community
Build ID: d72a592e2220974444146f5f4e76d6135af60ef9
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 3 Commit Notification 2021-04-21 11:25:06 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/75f5fdbbe48a847874397d9d126f832dbdfada5a

tdf#141703 Restore tab function in sd tables

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-04-21 12:46:51 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/29de1e98d30db95b4045537b6c867c7ea0090c4e

tdf#141703 Restore tab function in sd tables

It will be available in 7.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2021-04-22 15:06:04 UTC
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 41145efffe9d5af358a52b9e114bb01b98b3d7c2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Samuel, thanks for fixing this issue!!
Comment 6 Commit Notification 2021-04-22 19:27:47 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8ff18ded5970f8bb3e90b284081449235f515df4

tdf#141703: sd_uiimpress: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-04-24 18:58:14 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-7-1-3":

https://git.libreoffice.org/core/commit/0a98fb761f23cdf268fea9c8fca3fe8c14aa0cfe

tdf#141703 Restore tab function in sd tables

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Timur 2021-04-26 07:39:23 UTC
Tab to next cell and Shift to revert is fixed. 
Ctrl+Tab also goes to next cell but should make a tab instead. 
Since not done here, I'll open a new bug.