Bug 141823 - elementary: Please unify the design of the "function" icon in different sizes
Summary: elementary: Please unify the design of the "function" icon in different sizes
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.5.2 release
Hardware: All All
: medium enhancement
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.2.0 target:7.1.4 target:7.0.6
Keywords:
Depends on:
Blocks: Icon-Theme-Elementary
  Show dependency treegraph
 
Reported: 2021-04-22 06:41 UTC by Ming Hua
Modified: 2021-05-01 09:51 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the function icon used in various places in Calc (17.74 KB, image/png)
2021-04-22 06:41 UTC, Ming Hua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2021-04-22 06:41:18 UTC
Created attachment 171347 [details]
Screenshot of the function icon used in various places in Calc

The Calc module uses a "math function" icon in many places on its UI, such as formula bar and sidebar.  The image of this function icon is usually some variation of "f(x)".

In the elementary theme, it seems that the different sizes of this icon have rather distinctive designs.  As shown in the screenshot, the larger icon used as the sidebar selector is "f(x)", with parentheses, while the smaller icon used by the formula bar and inside the functions panel of sidebar is just "fx", without the parentheses.

This looks inconsistent and distracting IMHO, without much benefit.  It would be nice if their design can be unified, presumably by making the larger icon also "fx", because parentheses would make the image too busy on smaller size.

Screenshot is made with 7.0.5 on Windows 10:
Version: 7.0.5.2 (x64)
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: zh-CN (zh_CN); UI: en-US
Calc: threaded

...but also reproducible on 7.1.3 RC1 and 7.2.0 alpha0+ daily build.  Also should be reproducible for all platforms.
Comment 1 Commit Notification 2021-04-24 07:18:52 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/4fdbf2819e42760ecea27cc2a27b33d41f7b24bd

elementary: tdf#141823 unify function icons

It will be available in 7.0.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2021-04-24 07:20:06 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/c5d9d3a50ad8bfd39cbe498dc84cc2e51bbec686

elementary: tdf#141823 unify function icons

It will be available in 7.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Ming Hua 2021-04-24 15:24:32 UTC
Thanks for the quick fix, Rizmut!

(In reply to Commit Notification from comment #1)
> Rizal Muttaqin committed a patch related to this issue.
> It has been pushed to "libreoffice-7-0":
> 
> https://git.libreoffice.org/core/commit/
> 4fdbf2819e42760ecea27cc2a27b33d41f7b24bd
> 
> elementary: tdf#141823 unify function icons
> 
> It will be available in 7.0.7.
Although if you really plan to fix this for 7.0 series (I personally don't feel it's necessary), you probably want to also cherry-pick this patch to libreoffice-7-0-6 branch, as 7.0.6 RC1 has already been released and 7.0.6 is scheduled to be the last release of the 7.0 branch.  In other words, this commit will not make it in any of TDF's official 7.0 releases.
Comment 4 Commit Notification 2021-04-24 20:25:59 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fccb5adef2e323abd48238701fd9680428557466

elementary: tdf#141823 unify function icons

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-04-25 03:38:01 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0-6":

https://git.libreoffice.org/core/commit/1803a01fd85b5e765721a2ece2f4f9d3a23d6144

elementary: tdf#141823 unify function icons

It will be available in 7.0.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Ming Hua 2021-05-01 09:51:26 UTC
Confirmed in 7.2.0 master daily build (2021-04-30):
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: zh-CN
Calc: threaded

Thanks again, Rizmut!