Some CppUnittests use 'sal_Int32' instead of 'Color' to deal with color properties. If the fail, the output from the assert looks like - Expected: 14729932 - Actual : 14729933 while if 'Color' is used, the output is - Expected: Color: R:224 G:194 B:204 A:0 - Actual : Color: R:224 G:194 B:205 A:0 which is more human readable. This task is about looking for unittests where sal_Int32 is used and replaced them with Color. In Writer, the unittests are in sw/qa, in Calc in sc/qa and in Impress in sd/qa Example: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a7d862560e273442891432a88dff9a320c80575a
While on it, 0xffffff can be converted to COL_WHITE and 0x000000 to COL_BLACK
I would like to look in to this issue.
(In reply to Radhey Parekh from comment #2) > I would like to look in to this issue. Sure, looking forward to seeing a patch submitted to gerrit
Radhey Parekh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/54170057d54e08369ca2d753df48443ac8d5c5b6 tdf#141908 replace sal_Int32 with Color in sc_subsequent_filters-test2 It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Emircan Agac committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5d99a63fec50acca62fc9365708fc18bdcfedd68 tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Baran Aytas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b3a681a867eeb2d68abd4ce33b07cabfff224ef tdf#141908: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Xisco Faulí from comment #0) I have submitted a patch related to this. Please review it. It is my first time submitting a patch on gerrit.
(In reply to Rishav Chattopadhya from comment #7) > (In reply to Xisco Faulí from comment #0) > I have submitted a patch related to this. Please review it. It is my first > time submitting a patch on gerrit. You forgot to mention the link, but here it is https://gerrit.libreoffice.org/c/core/+/124091
(In reply to Buovjaga from comment #8) Thanks!
4k5h1t committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/31ded6f8718a90c7b3b9eb36909c2b7a0c6e9b68 tdf#141908 - CppUnittests: replace usage of sal_Int32 with color It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
4k5h1t committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/179e0c0cc5d3fd9610574e45a5204584f0e39176 tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henrik Palomäki committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1637f4449c10ec1f8869498ba0cafc61a8a77bbf tdf#141908 replace usage of sal_Int32 with colors in htmlexport It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rishav Chattopadhya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7a8cbfafca1906baad2bcbf8aa6717d197ae423a tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bbfce0b49fb11997af8eb03d40431b6a78f2aebe tdf#141908 replaced sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5fa0f02dace4538b0948bceddc23a9f55e1bf8a3 tdf#141908: CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c02dc02a98ff58e88cf0d6f805fcb5c2b7fb1cc7 tdf#141908: CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I would like to work on it
Harshita Nag committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6125517102493341b8172acd463dd9126afa7a64 tdf#141908: CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'll work on this.
Multi-hacks not assigned
Hi. I've added a patch for this on gerrit: https://gerrit.libreoffice.org/c/core/+/131408/1. Can someone please review it?
Tushar Jham committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/00937d1207394433970a4711fa4f51b072341290 tdf#141908:CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Siddhant Chaudhary committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8351179b787a10167e9e68584d3b3573fbdb6ebc tdf#141908 Replaced usage of sal_Int32 and sal_uInt32 with Color in unit tests. It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Re-evaluating the EasyHack in 2022 This issue is still relevant. The below search shows 23 instances: $ git grep -Fn "CPPUNIT_ASSERT_EQUAL(sal_Int32(0x"|grep -i color