Created attachment 171668 [details] Msgbox popup VBA Calc : Routine Msgbox(Application.Name) returns "Microsoft Excel" in place of "LibreOffice Calc" Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL
Code pointer: ScVbaApplication::getName in sc/source/ui/vba/vbaapplication.cxx.
Comment said // #TODO perhaps we should switch the return type depending of the filter // type, e.g. return Calc for Calc and Excel if it's an imported doc May be not so simple ?
When we use Libreoffice, vba macro must return "Libreoffice Calc". It doesn't matter if we use imported excel or not. The difference is important to adapt code if we use Excel or Calc. Because some instructions are differents (like filter).
(In reply to Laurent Louvet from comment #3) I agree; (OT) however, I'd like to point out that any difference in the behavior is a bug in LibreOffice; so any such conditional behavior in macros should be considered a temporary workaround; and users must be ready to fix their macros when LibreOffice fixes the difference.
Dear Laurent Louvet, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
(In reply to Mike Kaganski from comment #1) > Code pointer: ScVbaApplication::getName in > sc/source/ui/vba/vbaapplication.cxx. If just that expression is needed to be changed, I can do it. But if is needed a switch, I can not do it. Mike, please an answer.
(In reply to BogdanB from comment #6) I agree with comment 3. My opinion is: we don't need to try to outsmart the developer; we need to tell correctly what it is.
Some people are going to have shared macros suites that they deploy into Microsoft Word and Microsoft Excel, and this change will likely break that shared macro code.