Bug 142115 - Color of comments bar should follow the document canvas color
Summary: Color of comments bar should follow the document canvas color
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords:
Depends on:
Blocks: Options-Dialog-Colours
  Show dependency treegraph
 
Reported: 2021-05-06 09:21 UTC by Heiko Tietze
Modified: 2021-08-27 08:55 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with LibreOffice Dark color scheme (and Breeze Dark system theme) (78.51 KB, image/png)
2021-05-06 09:21 UTC, Heiko Tietze
Details
Screenshot of modified background colors and a comment (66.56 KB, image/png)
2021-05-06 09:55 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2021-05-06 09:21:58 UTC
Created attachment 171681 [details]
Screenshot with LibreOffice Dark color scheme (and Breeze Dark system theme)

Via Tools > Options > LibreOffice > Application Colors: Document Background it is possible to change the white canvas in, for example, Dark Gray 2 (see bug 141986). But the comments bar does not follow and remains something between Light Gray 4 and 5. The solution is to darken bright colors or to make dark colors brighter.
Comment 1 Mike Kaganski 2021-05-06 09:49:12 UTC
(In reply to Heiko Tietze from comment #0)
> Via Tools > Options > LibreOffice > Application Colors: Document Background
> it is possible to change the white canvas in, for example, Dark Gray 2 (see
> bug 141986). But the comments bar does not follow and remains something
> between Light Gray 4 and 5.

"Document background" has nothing to do with the background for the comments bar. The said color is "default paper color", while the comments are placed outside of the paper space. The proper color to use there would be "Application background", which is used for the "workspace" below the "paper".
Comment 2 Mike Kaganski 2021-05-06 09:55:42 UTC
Created attachment 171684 [details]
Screenshot of modified background colors and a comment

Here you may see the application and document background colors modified to show their distinction, and also the comment. Making comment bar follow document background would visually "expand" the paper, which is wrong; making it follow application background would make the comments appear "near" (but outside), connected by lines, making the proper look and feel.
Comment 3 Stéphane Guillou (stragu) 2021-07-27 02:43:35 UTC
I see three options:

- Option 1: "Follow" the document background colour automatically (but don't use the same, just something similar), so the comment's colours don't clash between the two areas. But trickier to get it right, and might frustrate users that it can't be changed to the colour the want?
- Option 2: New enhancement request for "Add a color setting for comment bar background in Options > LibreOffice > Application Colors", to expose that setting. Not sure if it should live in the "General" section or "Text document" section, given that it is only relevant to Writer but does not affect the document area per se.
- Option 3: Use the same colour as "document background" (Mike's idea). We should then decide between keeping a frame around the area to distinguish it from the application background, or let the comments "float" over the application background (but still having a button above to show or hide the comments, of course). The "floating" option might give it a more modern look, and might work better if comments end up being presented at different X positions in the future (to avoid overcrowded section and position mismatch).
Comment 4 Heiko Tietze 2021-08-27 08:54:54 UTC
The color follows now the section boundary.
Comment 5 Commit Notification 2021-08-27 08:55:02 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/67879304f61252838a6b2e2549d7205b445776f8

Resolves tdf#142115 - Make color of NotesPane customizable

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.