Bug 142122 - Applying changes to application color must not save it
Summary: Applying changes to application color must not save it
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected)
Hardware: All All
: medium enhancement
Assignee: Not Assigned
Depends on:
Blocks: Options-Dialog-Colours
  Show dependency treegraph
Reported: 2021-05-06 10:12 UTC by Heiko Tietze
Modified: 2023-01-20 10:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2021-05-06 10:12:24 UTC
Via Tools > Options > LibreOffice > Application Colors it is possible to change colors, for example the document background. The Apply function works nicely but takes the color into the current color scheme bypassing the Save function. 

Expected behavior: Apply affects the current module (or session) only and to make the change persistent it has to be saved explicitly.

Admittedly it's a convenience thing since Save always creates a new scheme. So to make this function a proper UX we need the Save function plus Save As (and Delete).
Comment 1 Roman Kuznetsov 2021-05-30 19:55:51 UTC
I'm not sure. May be just rename Apply to Save here. Or will not touch it at once?
Comment 2 Heiko Tietze 2021-05-31 07:53:41 UTC
The Apply button is the one at the dialog footer, we cannot change it to Save.
Comment 3 Heiko Tietze 2021-05-31 12:59:29 UTC
Don't see need for input from UX. Comments are welcome, of course.
Comment 4 Stéphane Guillou (stragu) 2021-07-26 21:37:23 UTC Comment hidden (obsolete)
Comment 5 Stéphane Guillou (stragu) 2021-07-27 01:35:02 UTC
Apologies, I understand now: changing a colour saves the value in the selected scheme automatically, which means it is not possible to go back to the default colours of the scheme.

One way to fix it would be to:
- automatically switch to a "User-defined" scheme as soon as a value is changed,
- change the "Save" button to "Save as...", to make it clearer that it will save it as a new, separate scheme.

The "auto-save" behaviour would be kept, but the user can always go back to a pre-existing scheme, or create a new one with "Save as...".

Version: / LibreOffice Community
Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 6 Rafael Lima 2023-01-19 14:02:30 UTC
Maybe we could do a bit differently.

When the user clicks OK / Apply in the main dialog, if any change has been made to the currently selected color scheme, then we can show a message box saying "Changes were made to the SCHEME_NAME color scheme. Would you like to overwrite the existing scheme or create a new one?".

This dialog could have 3 buttons: "Create New", "Overwrite" and "Cancel".

Clicking "Create New" would open the "Save scheme" dialog we already have.
Comment 7 Heiko Tietze 2023-01-20 10:04:06 UTC
(In reply to Rafael Lima from comment #6)
>we can show a message box...

Message dialogs interrupt the workflow and should be avoided. The correct workflow is to remember the previous values on Apply and bring it back per Reset. Or to just not save the values until the dialog/tab is closed.