Bug 142303 - GTK3/KF5 Text attributes > Text Animation > Delay; plus minus button
Summary: GTK3/KF5 Text attributes > Text Animation > Delay; plus minus button
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.4
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-15 19:35 UTC by raal
Modified: 2021-05-17 16:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
printscreen (107.66 KB, image/png)
2021-05-15 19:36 UTC, raal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2021-05-15 19:35:06 UTC
Description:
Buttons plus minus don't works

Steps to Reproduce:
1.impress file
2.insert shape
3.write text. Select text.
4. right click > Text attributes
5. Tab Text animation
6. Select some Effect
7. Deselect check box Delay
8. Button Up/Down

Actual Results:
Buttons don't works

Expected Results:
Buttons work


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 54387d1d35cb79a30be208052831de74efd8b2f2
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 1 raal 2021-05-15 19:35:45 UTC
Works in GEN, adding Caolán to CC.
Comment 2 raal 2021-05-15 19:36:10 UTC
Created attachment 172034 [details]
printscreen
Comment 3 Julien Nabet 2021-05-15 21:03:54 UTC
On pc Debian x86-64 with master sources updated today (65d6dc999c3e453498a007273cea26290c720f4c), I could reproduce this with gtk3 and kf5 rendering, not with gen one.
Comment 4 Julien Nabet 2021-05-15 21:18:13 UTC
Code pointer: cui/source/tabpages/textanim.cxx

I compared delay variable "m_xMtrFldDelay" and Pixels one "m_xMtrFldAmount", it seems the pb could be the missing call to "set_increments" and "set_range"

BTW, it seems there's also the same pb with "Animation cycles:" part.
Comment 5 Caolán McNamara 2021-05-17 08:00:02 UTC
There were GtkAdjustments added in 

commit 87e21946fa9a81c403a146d03579691537c1352c
Date:   Sat Aug 17 20:41:26 2013 -0300

    Convert text animations tab page to widget UI

but they weren't attached to the GtkSpinButtons
Comment 6 Commit Notification 2021-05-17 10:55:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eafad0719f50e34dadf9a32c2fb24cf00047f6eb

tdf#142303 connect adjustments to spinbuttons

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2021-05-17 11:03:36 UTC
done in devel, backport to 7-1 in gerrit
Comment 8 Julien Nabet 2021-05-17 11:48:48 UTC
With master sources updated today, I don't reproduce the pb with gtk3 and kf5 renderings for "Delay" and "Animation cycles" part.
Thank you Caolán!
Comment 9 Commit Notification 2021-05-17 16:23:03 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/561cfa00bca1c07778b03474bd5e2452f26c8839

tdf#142303 connect adjustments to spinbuttons

It will be available in 7.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.