Bug 142354 - Highlight top and bottom should ignore font dimensions when for space(-like) characters
Summary: Highlight top and bottom should ignore font dimensions when for space(-like) ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Highlight-Color
  Show dependency treegraph
 
Reported: 2021-05-18 13:51 UTC by Eyal Rozenberg
Modified: 2024-03-30 04:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
document exhibiting the issue (8.52 KB, patch)
2021-05-18 13:51 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2021-05-18 13:51:09 UTC
Created attachment 172135 [details]
document exhibiting the issue

Consider the attached document. The characters in it are set in Times New Roman, while the spaces are set in Noto Sans. While this is an artificial example, a similar situation often occurs with auto-generated documents, especially in certain RTL contexts, where the spaces between words somehow have different features than the words themselves.

Anyway, when you highlight the text, you get a "jittery" vertical highlight bar:

   +--+       +--+
   |  |       |  |
---+  +-------+  +----


---+  +-------+  +----
   +--+       +--+

which is annoying. It would also be somewhat annoying if the extensions were on _actual_ characters, but on spaces it really makes no sense.
 

Checked with:
Version: 7.1.3.2 / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US


... but I'm pretty sure this is issue goes way back.
Comment 1 Harshita Nag 2021-05-19 03:09:55 UTC
CONFIRMED on Ubuntu 18.04 LTS and LibreOffice 7.1.2.2

Version: 7.1.2.2 / LibreOffice Community
Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded
Comment 2 Harshita Nag 2021-05-19 03:14:07 UTC
Version: 5.1.6.2
Build ID: 07ac168c60a517dba0f0d7bc7540f5afa45f0909
CPU Threads: 8; OS Version: Linux 5.3; UI Render: default; 
Locale: en-IN (en_IN); Calc: group

In this, there are very slight extensions(on spaces) downwards.
Comment 3 Harshita Nag 2021-05-19 03:16:07 UTC
CONFIRMED on Ubuntu 18.04 LTS and LibreOffice 6.0.0.3 (exactly reproduced)

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk2; 
Locale: en-IN (en_IN); Calc: group
Comment 4 QA Administrators 2024-03-27 03:14:16 UTC Comment hidden (obsolete)
Comment 5 Haris 2024-03-30 04:37:11 UTC
This bug is still present on MacOS Sonoma 14.1.2 in the following two builds:

Stable Build
Version: 24.2.1.2 (AARCH64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 10; OS: macOS 14.1.2; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Master/Daily Build
Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: c4023d3ec604abfff38be2053e2989c7ec2ba8c1
CPU threads: 10; OS: macOS 14.1.2; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded