Created attachment 172298 [details] gdbtrace.log When testing bug 138556, I encounter the following crash: 1. New Writer, insert chart, right-click on the chart and change chart type to Stock Chart 1，OK. 2. Right-click on the chart and select Data Table. 3. Click on the cell of the 2nd column of 1st row (i.e., 9.1), then click "Delete Series" icon. 4. Click "Insert Series" icon. -> Crash. gdbtrace.log attached. Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 49af7e22e61c2e5d440ad55cd362388983e128ae CPU threads: 4; OS: Linux 5.12; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded and Version: 7.1.4.0.0+ / LibreOffice Community Build ID: b2fc048cb2d5f5bd1095a8110fa4a16a305a8acc CPU threads: 4; OS: Linux 5.12; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded Fedora 33 X64.
Can confirm on Fedora 34. I haven't tested yet with 7.2 though... It might be already fixed.
I can't reproduce it in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 42d2b2d55a27f11153ea1713737d93540a19211d CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Not reproducible in Version: 7.1.2.2 (x86) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: threaded either
Also no repro for me. So it's either Fedora or profile specific (please try on new profile). Please see if regression and bibisect.
I can't reproduce it with builds from libreoffice.org, only with the ones from Fedora repos, so I'd say this is Fedora-specific.
No need to delete the series to reproduce the crash - only inserting series is enough. So, the steps are: 1. Insert chart in Writer, change chart type to Stock Chart 1. 2. Go to Data Table. 4. Click "Insert Series" icon on the Data Table toolbar. -> Crash. And this is why the UITest test_stock_chart13_insert_series fails on my system, see https://bugs.documentfoundation.org/show_bug.cgi?id=138556#c11
Hi Caolán, does it crash on your end ? If I recall well, you use fedora as well...
I can reproduce in self-built 7-1 with gtk3 or gen. Not in 7-2, but I have 7-1 built with gcc and 7-2 with clang so it might not be a good comparison.
(In reply to Caolán McNamara from comment #8) The crash in my machine is also a self-build on Fedora 33, with the latest system updates.
I see it also in 6-4 so this has been going on for a while, trying to debug it
I have a workaround at least
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0d3dd9d9f6f0e6236c8db8ebdea44c78854639a8 tdf#142467 crash on calling 'getInfoHelper' in final class It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that makes it not crash, backport to 7-1 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/e06f2bb00137655dbf6f0a8c8c2fc555720f4d3f tdf#142467 crash on calling 'getInfoHelper' in final class It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Confirm fixed on master, no crash anymore. and, the UITest as submitted in bug 138556 can now pass on my system. Thanks Caolán.
sberg thinks this might be a gcc devirtualization bug and hopes to isolate it
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6cb1745c24c7651050e30216860c539fa13cc0e2 tdf#142467: Update comments with GCC bug ID It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Colan and sberg: I revisited this bug by chance, and come up the idea that whether the "final" in class CandleStickChartType /* final */ : public ChartType {...} should be restored now, as it has been 3 years and the upstream gcc bug has long been fixed.
yeah, probably if you want to try submitting that. It was probably a relatively small window of time where this problem exited
(In reply to Caolán McNamara from comment #19) https://gerrit.libreoffice.org/c/core/+/163447
Kevin Suo committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/90d22daf99e3d07ba19b7d16f240ab53b0873d49 tdf#142467: restore "final" in CandleStickChartType class It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.