Bug 142625 - [WMF] fail to load file with StretchDIB MR containing PNG or JPEG image
Summary: [WMF] fail to load file with StretchDIB MR containing PNG or JPEG image
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: emf-testbed
  Show dependency treegraph
 
Reported: 2021-06-02 18:47 UTC by Valek Filippov
Modified: 2022-05-04 09:12 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
WMF sample (1.01 KB, image/x-wmf)
2021-06-02 18:48 UTC, Valek Filippov
Details
How it looks like in MS Paint (1.06 KB, image/png)
2021-06-02 18:49 UTC, Valek Filippov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Valek Filippov 2021-06-02 18:47:37 UTC
Description:
LO fails to load WMF file with PNG or JPEG in the StretchDIB record.
In version 3.3.0.4 it was showing "Unknown file format" message dialog.
In version 6.2 and later it silently create "invisible" WMF object.

Steps to Reproduce:
Open attached WMF sample.

Actual Results:
Depends on the LO version, but never shows the expected content.

Expected Results:
To show 'PNG' and 'JPEG' text strings.


Reproducible: Always


User Profile Reset: No



Additional Info:
In theory it should show couple of bitmaps too, but none of the checked MS implementations are doing it.
Comment 1 Valek Filippov 2021-06-02 18:48:00 UTC
Created attachment 172580 [details]
WMF sample
Comment 2 Valek Filippov 2021-06-02 18:49:06 UTC
Created attachment 172581 [details]
How it looks like in MS Paint
Comment 3 Commit Notification 2021-06-07 11:38:00 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6bebaddb39849422dffa16316c543fc69305f31a

WMF tdf#142625 Continue read records if unimlemented features found

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-06-08 20:40:49 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b6a30a9db00f92eec7387a577321d65d47ff4af5

WMF tdf#142625 Refactor Bitmap records, to better handle missing features

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2022-05-03 12:22:16 UTC
A polite ping to Bartosz:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks
Comment 6 Bartosz 2022-05-04 09:08:56 UTC
Unfortuntaly still proper PNG and JPEG support needs to be added. With the latest fixes, if unsupported image format would be found, then the whole stream will not be interrupted (as it was previously - nothing displayed).