Bug 142806 - Freeze/hang/crash when exporting to PDF with style inspector panel active
Summary: Freeze/hang/crash when exporting to PDF with style inspector panel active
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Printing and PDF export (show other bugs)
Version:
(earliest affected)
7.1.0.1 rc
Hardware: All All
: medium major
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.8.0 target:24.2.1 target:7.6.5
Keywords: implementationError
: 144641 (view as bug list)
Depends on:
Blocks: Crash-Assert Style-Inspector
  Show dependency treegraph
 
Reported: 2021-06-11 20:25 UTC by Telesto
Modified: 2024-05-30 17:36 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-06-11 20:25:57 UTC
Description:
Freeze/hang when exporting to PDF

Steps to Reproduce:
1. Open attachment 150827 [details] (bug 124798)
2. PDF export (at default settings) (in GUI)

Actual Results:
Waited 90 seconds..

Expected Results:
15 seconds like 7.0


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 239b4bb27fd8db26e8416045b3015688a8b1b0ae
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-06-11 20:27:09 UTC Comment hidden (obsolete, wrong)
Comment 2 Timur 2021-06-12 07:47:23 UTC
I don't know why you are multiplying bugs, same file, same convert issue. 
And putting b request  - instead of doing it yourself. 
Try to open both 1st time after boot and see time and compare further runs. 
I don't think it's repeatable.
Comment 3 Telesto 2021-06-12 08:00:56 UTC
(In reply to Timur from comment #2)
> I don't know why you are multiplying bugs, same file, same convert issue. 
This is recent.. found in 7.2 not in 7.1

> And putting b request  - instead of doing it yourself.
Bibisect-request simply means its bibisectable and should be bibisected. 
 
> Try to open both 1st time after boot and see time and compare further runs. 
> I don't think it's repeatable.

-> That appears to be the case; weird
Comment 4 Telesto 2021-06-12 08:03:30 UTC
Reviving; updated STR
1. Open attachment 150827 [details] (bug 124798)
2. Sidebar -> Activate style inspector panel
2. PDF export (at default settings) -> Hang
Comment 5 Timur 2021-06-14 10:04:39 UTC
Repro hang with style inspector in 7.2+. So far I set implementationError.
Comment 6 Telesto 2021-06-14 12:59:48 UTC
@Jim
You might be interested based on you're work related to sidebar and such..
Feel free to un CC yourself, if uninterested
Comment 7 Telesto 2021-09-21 15:14:48 UTC
*** Bug 144641 has been marked as a duplicate of this bug. ***
Comment 8 QA Administrators 2023-09-22 03:16:44 UTC Comment hidden (obsolete)
Comment 9 Matt K 2023-12-16 00:46:48 UTC
I get a debug assert/crash when trying to open the example doc in a debug build and doing "File"->"Export as..."->"Export as PDF..."->"OK".  One thing to note is that I see a warning panel message that says "Missing hyphenation data: Please install the hyphenation package for locale "de-DE"" and the first page renders just a gray background rather than an actual page.  After install the german dictionary from https://extensions.libreoffice.org/en/extensions/show/german-de-de-frami-dictionaries, I clicked in the gray area and page 1 appeared.  Still get the following assert:

        assert(pStartFrame == pEndFrame); // link or field all in 1 frame

with the following stack trace:

>	swlo.dll!SwRootFrame::CalcFrameRects(const SwShellCursor & rCursor, std::vector<SwRect,std::allocator<SwRect>> & rRects, SwRootFrame::RectsMode eMode) Line 2602	C++
 	swlo.dll!`anonymous namespace'::GetCursorRectsContainingText(const SwCursorShell & rShell) Line 354	C++
 	swlo.dll!SwEnhancedPDFExportHelper::EnhancedPDFExport(const o3tl::strong_int<unsigned short,LanguageTypeTag> eLanguageDefault) Line 2224	C++
 	swlo.dll!SwEnhancedPDFExportHelper::SwEnhancedPDFExportHelper(SwEditShell & rSh, OutputDevice & rOut, const rtl::OUString & rPageRange, bool bSkipEmptyPages, bool bEditEngineOnly, const SwPrintData & rPrintData) Line 2079	C++
 	swlo.dll!SwXTextDocument::render(long nRenderer, const com::sun::star::uno::Any & rSelection, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rxOptions) Line 3020	C++
 	pdffilterlo.dll!PDFExport::ExportSelection(vcl::PDFWriter & rPDFWriter, const com::sun::star::uno::Reference<com::sun::star::view::XRenderable> & rRenderable, const com::sun::star::uno::Any & rSelection, const StringRangeEnumerator & rRangeEnum, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rRenderOptions, long nPageCount) Line 180	C++
 	pdffilterlo.dll!PDFExport::Export(const rtl::OUString & rFile, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rFilterData) Line 1089	C++
 	pdffilterlo.dll!PDFFilter::implExport(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rDescriptor) Line 181	C++
 	pdffilterlo.dll!PDFFilter::filter(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rDescriptor) Line 246	C++
 	sfxlo.dll!SfxObjectShell::ExportTo(SfxMedium & rMedium) Line 2595	C++
Comment 10 Matt K 2023-12-16 00:49:22 UTC
Here is my info:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9382734da1838485bfe7d2ae912b8d61f24231e4
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Updating title to show it's now a crash.  Should the priority of this increase now that it's a crash?
Comment 11 Matt K 2023-12-16 05:47:09 UTC
I isolated the assert crash to the following combined changes:

https://git.libreoffice.org/core/+/a1b0fc647d14dc36e9fe238d5bfc81ebcfa1d5dc
and
https://git.libreoffice.org/core/+/5726be1314517d47dd733aabe64a3d85cce094c5

Adding to CC Michael Stahl.
Comment 12 Commit Notification 2024-01-25 10:47:24 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9ba8d68c2b2fd06340bbdcb61dc3d57f6e3eb974

tdf#142806 sw: PDF export: fix multi-frame links/fields

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2024-01-25 10:47:27 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5314947eea119a1ed4960e23c61530669b97468e

tdf#142806 sw: slowness if Style Inspector visible during PDF export

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Michael Stahl (allotropia) 2024-01-25 10:54:36 UTC
fixed the crash on master

the performance problem turned out to be very easy to fix too
Comment 15 Commit Notification 2024-01-26 08:56:37 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/6155fe977b0462136fcccbc6f052518041b5e66f

tdf#142806 sw: slowness if Style Inspector visible during PDF export

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2024-01-26 08:57:40 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/13c748e7998b6df02e23815f337e9ab4d04172f3

tdf#142806 sw: PDF export: fix multi-frame links/fields

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2024-01-26 08:57:43 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/83d68d6ff1d19abf18bac8bfa35b200f45d91b5c

tdf#142806 sw: PDF export: fix multi-frame links/fields

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.