Bug 142823 - Draw Spanish UI does not distinguish two buttons for 3D objects
Summary: Draw Spanish UI does not distinguish two buttons for 3D objects
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2 all versions
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-12 17:43 UTC by Lobaluna
Modified: 2022-02-11 21:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lobaluna 2021-06-12 17:43:57 UTC
Description:
The problem is that although in English UI and guides there are two buttons with almost the same names, in Spanish they were translated with the exact same name: "To 3D Rotation Object" and "In 3D Rotation Object" were both translated to "En cuerpo de giro 3D".

There is no way to differentiate them in the interface, because in addition, both in English and in Spanish they have the same icon, which is another bug, but I will file it here.

(In addition to the fact that the guide itself does not help to clarify the subject at all.) I'll file it here, please.

I think we need to change the terminology, icons and explanations.

A proposal to do it is as follows: There is something that also differentiates these two functions. It is the axis of rotation to create the 3D object. So my proposal to change the Spanish UI is: 

"A objeto 3D por giro (eje predet.)" = "To 3D Rotation Object". With this function you convert a 2D object to a 3D one using a predetermined rotation axis (the left side of the invisible bounding box of the 2D object).

"A objeto 3D por giro" = "In 3D Rotation Object". With this function the user can move and define the axis of rotation of the new 3D object.

Steps to Reproduce:
1.Open a Draw file.
2.Add the two buttons "En cuerpo de giro 3D" for "Configuración 3D" toolbar. The have the same icon in LibO 6.4, but in LibO there is a slight difference (good!)
2.Draw a 2D object
3.Use "En cuerpo de giro 3D" for each button added in toolbar.

As you can see in LibO 7, the two buttons correspond to .uno:ConvertInto3DLathe and .uno:ConvertInto3DLatheFast, so in Spanish UI there must be a different translation for each one of them.

Actual Results:
Two different objects are created because the two buttons do slightly different functions

Expected Results:
The Spanish UI to have differentiated names for the two buttons


Reproducible: Always


User Profile Reset: Yes



Additional Info:
LibreOffice 6.4
Comment 1 Julien Nabet 2021-06-14 20:05:05 UTC
On pc Debian x86-64 with master sources updated today, with Spanish UI. I don't reproduce this.

When enabling "Configuración 3D" toolbar, I don't have these 2 buttons.

After having created a 2D shape, I right clicked on it and had in "Convertir" entry:
- ...
- en 3D
- en cuerpo de giro 3D
- ...

Did I miss something?
Comment 2 Lobaluna 2021-06-15 00:32:14 UTC
You are right. You need to add those two buttons to the toolbar.

1. Try going to Personalizar>Teclado, then Buscar=3D.
2. You will see two buttons withe very same name. The performa the same function with different settings.

You can add those 2 buttons to your toolbar in order to test the function.
Comment 3 QA Administrators 2021-06-15 03:42:34 UTC Comment hidden (obsolete)
Comment 4 Julien Nabet 2021-06-15 16:44:24 UTC
Thank you for your feedback.

On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.

Adolfo: thought you might be interested in this one.
In translations/source/es/officecfg/registry/data/org/openoffice/Office/UI.po:
8809 #. 2vbYM
8810 #: DrawImpressCommands.xcu
8811 msgctxt ""
8812 "DrawImpressCommands.xcu\n"
8813 "..DrawImpressCommands.UserInterface.Commands..uno:ConvertInto3DLatheFast\n"
8814 "Label\n"
8815 "value.text"
8816 msgid "To 3D ~Rotation Object"
8817 msgstr "En cuerpo de gi~ro 3D"

8939 #. pQhVJ
8940 #: DrawImpressCommands.xcu
8941 msgctxt ""
8942 "DrawImpressCommands.xcu\n"
8943 "..DrawImpressCommands.UserInterface.Commands..uno:ConvertInto3DLathe\n"
8944 "Label\n"
8945 "value.text"
8946 msgid "In 3D Rotation Object"
8947 msgstr "En cuerpo de giro 3D"
Comment 5 Julien Nabet 2021-07-23 20:23:25 UTC
Regina: the bug is about these 2 uno functions:
- uno:ConvertInto3DLatheFast -> "To 3D ~Rotation Object" SID_CONVERT_TO_3D_LATHE_FAST

- uno:ConvertInto3DLathe -> "In 3D Rotation Object"
SID_CONVERT_TO_3D_LATHE

Searching about SID_CONVERT_TO_3D_LATHE_FAST, I see in sd/source/ui/view/drviews2.cxx:
   3377         case SID_CONVERT_TO_3D_LATHE_FAST:
   3378         {
   3379             /* The call is enough. The initialization via Start3DCreation and
   3380                CreateMirrorPolygons is no longer needed if the parameter
   3381                sal_True is provided. Then a tilted rotary body with an axis left
   3382                besides the bounding rectangle of the selected objects is drawn
   3383                immediately and without user interaction.  */
   3384             mpDrawView->SdrEndTextEdit();
   3385             if(GetActiveWindow())
   3386                 GetActiveWindow()->EnterWait();
   3387             mpDrawView->End3DCreation(true);
   3388             Cancel();
   3389             rReq.Ignore();
   3390             if(GetActiveWindow())
   3391                 GetActiveWindow()->LeaveWait();
   3392         }

See https://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviews2.cxx?r=b1668edf#3377

Searching about SID_CONVERT_TO_3D_LATHE, I see in sd/source/ui/func/fusel.cxx:
   1127         case SID_CONVERT_TO_3D_LATHE:
   1128         {
   1129             eMode = SdrDragMode::Mirror;
   1130             bSuppressChangesOfSelection = true;
   1131 
   1132             if ( mpView->GetDragMode() != eMode )
   1133                 mpView->SetDragMode(eMode);
   1134 
   1135             if (!mpView->Is3DRotationCreationActive())
   1136                 mpView->Start3DCreation();
   1137 
   1138             bSuppressChangesOfSelection = false;
   1139         }
see https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fusel.cxx?r=bfc1600c#1127

As if SID_CONVERT_TO_3D_LATHE was to start 3D creation and SID_CONVERT_TO_3D_LATHE was to end 3D creation
If yes, why aren't they named:
SID_CONVERT_TO_3D_BEGIN/uno:ConvertInto3DBegin and SID_CONVERT_TO_3D_END/uno:ConvertInto3DEnd
?

I suppose I must have missed something.
Any thoughts here?
Comment 6 Lobaluna 2022-02-11 21:45:07 UTC
Sorry, but I am not able to correct o dismiss the code.

I just know there are two almost different functions that deserve a different name in the UI. They are almost different because they perform similar functions (one with initial values provided by Draw)