Bug 142832 - LibreOffice doesn't act as though it's in full screen
Summary: LibreOffice doesn't act as though it's in full screen
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Full-Screen-Mode
  Show dependency treegraph
 
Reported: 2021-06-13 07:38 UTC by jhager4420
Modified: 2023-10-04 05:23 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Displaying behavior not intended (735.28 KB, video/x-matroska)
2021-06-13 07:38 UTC, jhager4420
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jhager4420 2021-06-13 07:38:58 UTC
Created attachment 172845 [details]
Displaying behavior not intended

In windows 8/8.1/10(beyond) and linux MNT/debian the window that contains the libreoffice document/spreadsheet/whatever will be full screen without acting like it's full screen. If I move the mouse cursor to the very top right to click close on whatever I'm working on, it will instead pull up whatever window is behind libreoffice and close that instead, pretending like libreoffice isn't even open. This is back from as early at 5.0 libreoffice all the way up until recent releases, on both windows from multiple generations and several distros of linux. This happens on both single-screen setups and multi-screen setups (regardless of what monitor libreoffice is open on.)
I have attached a video copy of what happens, and what has been happening for years for me across multiple releases of libreoffice and multiple operating systems and multiple computers. Is this ever going to be addressed or is this going to be a motivation to just move elsewhere?
Comment 1 V Stuart Foote 2021-06-13 18:02:35 UTC
Hmm, the video clip is compelling. I see Google closing with selection of the CSD closer on the LibreOffice app frame holding a Calc session.

But, I have never experienced nor seen the issue reported before this, I can not confirm on Windows builds. Not clear how the incorrect frame focus could end up outside of LibreOffice.

Weird!  @Mike any thoughts?

Version: 7.1.4.2 (x64) / LibreOffice Community
Build ID: a529a4fab45b75fefc5b6226684193eb000654f6
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 2 Mike Kaganski 2021-06-13 18:10:23 UTC
(In reply to jhager4420 from comment #0)
> Is this ever going to be addressed or is this going to be a motivation to
> just move elsewhere?

(/me rants)

I was interested reading the report, until I came to the last sentence, at which point I thought: why a user starts with some accusations, as if (1) it was already reported by them previously - which would imply there's a bug number for the problem; and (2) there was some unfulfilled promise. Well, no, not interested - as a volunteer, I would like to work on issues that don't start with things that make me feel abused.

(In reply to V Stuart Foote from comment #1)

Can only tell that I also can't repro with the same version. :-) And the report doesn't mention a version to try, nor any other details like render type.
Comment 3 jhager4420 2021-06-14 01:09:33 UTC
(In reply to Mike Kaganski from comment #2)

> I was interested reading the report, until I came to the last sentence, at
> which point I thought: why a user starts with some accusations, as if (1) it
> was already reported by them previously - which would imply there's a bug
> number for the problem; and (2) there was some unfulfilled promise. Well,
> no, not interested - as a volunteer, I would like to work on issues that
> don't start with things that make me feel abused.
> 
> (In reply to V Stuart Foote from comment #1)
> 
> Can only tell that I also can't repro with the same version. :-) And the
> report doesn't mention a version to try, nor any other details like render
> type.

You're right, I was unnecessarily aggressive and I can only apologize. I've experienced this issue for years now and it kind of boiled over a bad day yesterday when I ended up closing a window with a form filled out and lost all the information in it trying to close a calc document that was in front of it. Again, I'm sorry.

I am currently on version 7.1.3.2 (build 47f78053abe362b9384784d31a6e56f8511eb1c1), but like I said this has happened since I started using the program somewhere back in version 5.
Comment 4 Mike Kaganski 2021-06-14 16:20:01 UTC
I still can't reproduce, unfortunately.

But some possible code pointers:
WM_GETMINMAXINFO is handled in SalFrameWndProc (vcl/win/window/salframe.cxx); it calls ImplHandleMinMax, and the latter calls ImplSalCalcFullScreenSize. There's some code that handles multi-monitor configuration; it's interesting if jhager4420 uses multi-monitor configuration maybe? That would explain why it's not reproducible in all cases.
Comment 5 Mike Kaganski 2021-06-14 17:08:54 UTC
A blind fix is at https://gerrit.libreoffice.org/c/core/+/117129. It seems plausible (in case OP confirms use of multi-monitor configuration), but no guarantee :-)
Comment 6 Mike Kaganski 2021-06-14 17:20:38 UTC
(In reply to jhager4420 from comment #0)
> In windows 8/8.1/10(beyond) and linux MNT/debian ... on both windows from
> multiple generations and several distros of linux. This happens on both
> single-screen setups and multi-screen setups

Hmm, well - that's sad. However, the change I'm doing looks still valid - but in the light of this info, it's unlikely that it would fix it (the change is for Windows, and for multi-monitor case only).
Comment 7 Commit Notification 2021-06-14 19:11:29 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/57d122258437c0a14b303a8d961aa5e8f6f67f57

tdf#142832: a blind fix - calculate rectangle size properly

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Mike Kaganski 2021-06-14 19:16:01 UTC
@jhager4420:

Please try tomorrow on Windows, using a daily build with the change included, and post the result in a comment here, along with information from Help->About. If it will be fixed, then this bug should be set to RESOLVED/FIXED, and track Linux case in a separate issue (because this is a system-specific code, and works differently in different OS and window managers). If it will stay unfixed, then this should be set back to UNCONFIRMED (since it was not reproduced independently yet).
Comment 9 Commit Notification 2021-06-15 04:22:44 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3c472ffe90bf5c496411c6d37ae832d9181c4ec9

Revert "tdf#142832: a blind fix - calculate rectangle size properly"

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Mike Kaganski 2021-06-15 04:27:38 UTC
No, it was a wrong change. To be able to fix, one needs to reproduce first - and this needs investigation what are the specific circumstances that make it happen (because it's not universal problem).
Comment 11 jhager4420 2021-06-20 07:59:34 UTC
(In reply to Mike Kaganski from comment #8)
> @jhager4420:
> 
> Please try tomorrow on Windows, using a daily build with the change
> included, and post the result in a comment here, along with information from
> Help->About. If it will be fixed, then this bug should be set to
> RESOLVED/FIXED, and track Linux case in a separate issue (because this is a
> system-specific code, and works differently in different OS and window
> managers). If it will stay unfixed, then this should be set back to
> UNCONFIRMED (since it was not reproduced independently yet).

Sorry the late reply, haven't had time to get it tested. It still seems to be exhibiting the same behavior where it closes a window at the very top right of the button.
Tested on builds dc7bc263d05f74cd0e788883ed99e71809bbfc75 and d7b9b9e8e02aefd61669e07543fc370b0c58207f.

A new piece of information I just found out (I don't usually have a document open on my rightmost monitor) is that it happens on all monitors but the one I have at the far right. I no longer have a multi monitor setup on a linux box so testing on one of those isn't something I can do at the moment.
Comment 12 Mike Kaganski 2021-06-20 08:01:45 UTC
(In reply to jhager4420 from comment #11)
> I no longer have a multi monitor setup on a linux
> box so testing on one of those isn't something I can do at the moment.

But you wrote in comment 0:

> This happens on both single-screen setups and multi-screen setups (regardless of what monitor libreoffice is open on.)

So - is it actually happening on single-monitor?
Comment 13 jhager4420 2021-06-20 10:40:13 UTC
(In reply to Mike Kaganski from comment #12)
> (In reply to jhager4420 from comment #11)
> > I no longer have a multi monitor setup on a linux
> > box so testing on one of those isn't something I can do at the moment.
> 
> But you wrote in comment 0:
> 
> > This happens on both single-screen setups and multi-screen setups (regardless of what monitor libreoffice is open on.)
> 
> So - is it actually happening on single-monitor?

I first noticed it years ago on an old laptop that ran linux with just the built in screen, I don't really do any document processing on laptops anymore but a brief test on a laptop running windows with two screens doesn't seem able to replicate the issue. I do remember seeing it last on that old laptop about 2019, but haven't used it since then, and it's been on at least three different desktops. I'll continue testing on the multimonitor display and see if there's some specific config that's causing it.
Comment 14 [REDACTED] 2021-06-23 13:00:04 UTC
*** Bug 143004 has been marked as a duplicate of this bug. ***
Comment 15 Xisco Faulí 2021-11-23 10:29:50 UTC
Moving to NEW