Bug 143117 - Artifacts remain when editing long text box in Impress
Summary: Artifacts remain when editing long text box in Impress
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Textbox
  Show dependency treegraph
 
Reported: 2021-06-29 15:23 UTC by Aron Budea
Modified: 2022-11-04 05:09 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample ODP (22.68 KB, application/vnd.oasis.opendocument.presentation)
2021-06-29 15:23 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2021-06-29 15:23:29 UTC
Created attachment 173273 [details]
Sample ODP

- Open the attached ODP,
- In the text box, start deleting text from the back using backspace.

=> Note the remaining artifacts (also shown in the pasted image below the text box).

Observed in LO Version: 7.3.0.0.alpha0+ (5e37a1d89dfaa12690841213bce0cb6d05faf90a), 6.0.0.3 / Ubuntu.
No artifact in 5.4.0.3.

Regression from the following commit. Same commit that has been identified in bug 131627. Adding CC: to Armin Le Grand.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f06b48a5dddab20fd1bbf9b5f3e8543593f5e590
author		Armin Le Grand <Armin.Le.Grand@cib.de>	2017-08-04 18:56:43 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-08-10 15:17:58 +0200

"editviewoverlay: Allow EditView to run in Overlay"

A small annoyance, not related to the issue or the regression is that not the whole text takes editing focus when trying to click into it, it only reacts until the first "e" in "here".
Comment 1 Armin Le Grand 2022-01-05 10:00:30 UTC
maybe double to tdf#131627
Comment 2 Armin Le Grand 2022-11-01 11:00:31 UTC
Tried, cannot reproduce with

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8ec62a84c84d818d01cd3e6dcb874e1a801512c7
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (C.UTF-8); UI: en-US
Calc: threaded

The mentioned annoyance happens, so I tried to reproduce that shape, but failed. All I could reproduce does not show that.
-> How was that shape created?
-> What type of shape is it?
-> Can you add a description that starts with an empty document, please?
Comment 3 Aron Budea 2022-11-04 05:09:22 UTC
Indeed, and the fix could be reverse bibisected to the following commit in 7.5:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b1a57e075af70135703e38337e1096b2f248ebd
author		Caolán McNamara <caolanm@redhat.com>	2022-01-05 20:40:26 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2022-08-16 09:49:59 +0200

"tdf#94223 always visualize surrounding frame for active text object"

(In reply to Armin Le Grand from comment #2)
> The mentioned annoyance happens, so I tried to reproduce that shape, but
> failed. All I could reproduce does not show that.
> -> How was that shape created?
> -> What type of shape is it?
> -> Can you add a description that starts with an empty document, please?
The ODP came from Michael, I'm afraid I have no further information on how it was created, thought perhaps he can comment on it.

It might be worth looking into the XML and comparing it to a regular text box sometimes.

For now let me close this, as the original bug is resolved. If there's interest in the text box, I can create a separate bug report.