Bug 143245 - Clicking anywhere in the Description area will trigger the Form creation window
Summary: Clicking anywhere in the Description area will trigger the Form creation window
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
7.1.3.2 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.3.0 target:7.1.6 target:7.2....
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-07-07 20:23 UTC by Rafael Lima
Modified: 2021-07-15 15:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Image showing the problem (57.16 KB, application/vnd.oasis.opendocument.graphics)
2021-07-07 20:23 UTC, Rafael Lima
Details
Image showing the problem (UPDATED) (58.76 KB, application/vnd.oasis.opendocument.graphics)
2021-07-07 20:25 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2021-07-07 20:23:01 UTC
Created attachment 173431 [details]
Image showing the problem

In Base's main window there's a "Description" area with two functions:
- Create Form in Design View
- Use Wizard to Create Form

The problem is that when the user clicks anywhere in this "Description" area, without selecting any of the two options above, one of them gets triggered (the last one used).

I use Base quite often and this behavior is not good for me as a user, because I often accidentally click in this area and the Form creation window opens unexpectedly.

See the attached ODG image for more information.

IMO if the user clicks this area, nothing should happen.

It should be noted that the other area at the bottom of the UI does not have this behavior, which makes me believe that this is a bug.
Comment 1 Rafael Lima 2021-07-07 20:25:49 UTC
Created attachment 173432 [details]
Image showing the problem (UPDATED)

Consider this image instead of the previous one.
Comment 2 Robert Großkopf 2021-07-08 05:44:21 UTC
Could confirm the buggy behavior. 
1. Click on "Create Form in Design View" opens design view. 
2. Close design view.
3. Click anywhere, for example in the pane "Forms".
4. Click anywhere in the pane "Tasks".
5. Design view will be opened but isn't clicked.

This buggy behavior doesn't appear in LO 7.0.5.2, appears in LO 7.1.5.1 and also 7.1.0.3. Seems it is introduced with LO 7.1. So a regression.
Comment 3 Julien Nabet 2021-07-12 20:30:11 UTC
Caolán: another bug I can reproduce on pc Debian x86-64 with master sources updated today but only with gen and kf5 renderings, not with gtk3.

By the way, I noticed the cross to close the window didn't appear on Design view the first time for gen and kf5.
I also noticed that if I click on form wizard, the next time I click on "empty zone" (see attachment 2), it'll open form wizard not Design view.
Comment 4 Caolán McNamara 2021-07-13 15:39:26 UTC
probably the "Single Click Activate" isn't quite right for vcl
Comment 5 Caolán McNamara 2021-07-13 15:59:02 UTC
https://gerrit.libreoffice.org/c/core/+/118861 is proposed fix
Comment 6 Commit Notification 2021-07-13 19:57:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c4adcec93784d4fc42f6119d761bb23463b99e2

tdf#143245 activate-on-single-click only if 'up' is at active entry

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2021-07-13 19:58:42 UTC
backports to 7-2 and 7-1 in gerrit
Comment 8 Julien Nabet 2021-07-13 20:31:46 UTC
I confirm I don't reproduce this anymore after Caolán's patch.
Thank you!
Comment 9 Commit Notification 2021-07-14 07:59:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/bfc49fc16c1cc9b9a5dee406fe7348c079c45ba6

tdf#143245 activate-on-single-click only if 'up' is at active entry

It will be available in 7.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-07-14 10:03:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/fc319d0872d0873ab22b98ba457fdce5cf3cb323

tdf#143245 activate-on-single-click only if 'up' is at active entry

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-07-15 15:08:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1-5":

https://git.libreoffice.org/core/commit/ef86453a3f1dc0f3c73e731aaccfc4354bae70cc

tdf#143245 activate-on-single-click only if 'up' is at active entry

It will be available in 7.1.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.