Bug 143246 - Color picker doesn't load previously-picked color
Summary: Color picker doesn't load previously-picked color
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: Color-Picker-Dialog
  Show dependency treegraph
Reported: 2021-07-07 21:28 UTC by Ryan Johnson
Modified: 2022-06-16 23:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:

color picker uses original color not last color (117.96 KB, image/png)
2021-07-07 21:28 UTC, Ryan Johnson

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Johnson 2021-07-07 21:28:47 UTC
Created attachment 173433 [details]
color picker uses original color not last color


Modify paragraph style.
Change font color.
Observe custom color picker loads wrong color.

It loads the color that was selected at instantiation of the Paragraph Style editor. The color that is passed to the color picker does not reflect any changes during the lifetime of the Paragraph Style window, when this would make the most sense.

The user wants to change the color, apply it to see how it looks, and then adjust the color again if it doesn't look right. They don't want to start from the original color. They want to start from the last color they picked when changing it again.
Comment 1 V Stuart Foote 2021-07-08 13:29:50 UTC
Confimring behavior on
Version: (x64) / LibreOffice Community
Build ID: 2ca94649fd6dbdcab938c55c28b6a950a9634a34
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

I understand the work flow, making sucessive changes in text color for the paragraph style being edited.  

Something seems a bit off. A color swatch picked from the active palette, or from the bar of recents, will reset the base color for the 'Custom Color...' picker widget immediately. Yet a color pick made from the widget does not. Both show the selected color in the text preview--but base color value for the custom color widget does not get updated.

I don't think it is intentional (to be able to revert a color pick) so seems like an implementation issue.  Just not sure what the UI behavior should be mixing the colors from the active palette with the custom color picker.
Comment 2 Heiko Tietze 2021-07-09 07:04:20 UTC
And "Apply" is not taking the color into the list of recently used. But Ok does, and shows this color in the picker later. Don't know if this was done intentionally and the use case to keep the previous color so it's possible to reset after Apply is quite far-fetched. So let's treat this as a bug.

Steps again:

1. Right click a paragraph style on the Stylist
2. Change the font color to a custom color (eg from yellow to red)
3. Apply
4. Open the custom color picker again and it's initialize with the original color (yellow) not the actual (red)