Bug 143293 - slideshow_info is only ever sent once, even if presentation is switched
Summary: slideshow_info is only ever sent once, even if presentation is switched
Alias: None
Product: Impress Remote
Classification: Unclassified
Component: General (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Andrzej Hunt
Whiteboard: QA:needsComment
Depends on: 119312
  Show dependency treegraph
Reported: 2021-07-10 16:40 UTC by Andrzej Hunt
Modified: 2022-05-02 11:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Andrzej Hunt 2021-07-10 16:40:53 UTC
slideshow_info (containing the slideshow title) is currently sent only once - when we first connect the remote client. That seems wrong - surely the user could switch to a different presentation later on:

I noticed this when reviewing a crash-fix - it turns out that we unconditionally try to read a title even if there's no presentation available - which is being fixed in:

That fix will stop us from trying to send a title if there's no open presentation - as a followup I'd like to play around with moving slideshow_info to the same place that we send slideshow_started, i.e. here:

This seems to have existed since 8 years ago in:

Steps to Reproduce:
Pure speculation (but I'll update this once I get round to working on the bug):
1. Open a presentation.
2. Connect the remote.
3. Open a different presentation, and start presenting.

Actual Results:
Pure speculation: the title of presentation 1 is shown.

Expected Results:
The title of presentation 2 is shown.

Reproducible: Always

User Profile Reset: No

Additional Info: