Description: In Writer, there are 12 icons available for table borders. The icons file names exist from "fr01.*" to "fr012.*". Writer needs 2 new icons for diagonal left and diagonal right borders. These icons are needed for https://bugs.documentfoundation.org/show_bug.cgi?id=51665 . It will be good if: "fr013.*" -> for diagonal left border "fr014.*" -> for diagonal right border. Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 8b7f948d9d79393bc6c1b11d239706666fd5d7de CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Created attachment 173492 [details] border icons in MS office (left) and LibreOffice (right)
@Heiko For keeping tabs..
Yes, Rizal offered his service and asked for this ticket on Telegram.
(In reply to Heiko Tietze from comment #3) > Yes, Rizal offered his service and asked for this ticket on Telegram. Intended for mentioning: The Table -> Properties -> Border dialog has to be adapted to support diagonal borders too (bug 51665). Aside from changes in functioning (my major off-topic concern) it might need icons too?
https://gerrit.libreoffice.org/c/core/+/118821
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/08f7cdb51775dc0988d4bb9cd1d0b8f9487861aa tdf#143300 add diagonal border for Writer table It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #6) > Rizal Muttaqin committed a patch related to this issue. Guess it's solved with the patch.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cfb25346ffe0ec8a65b4db2630ea615077fba277 Breeze: tdf#143300 add diagonal border line icons It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Telesto from comment #4) > (In reply to Heiko Tietze from comment #3) > > Yes, Rizal offered his service and asked for this ticket on Telegram. > > Intended for mentioning: The Table -> Properties -> Border dialog has to be > adapted to support diagonal borders too (bug 51665). Aside from changes in > functioning (my major off-topic concern) it might need icons too? I guess my patch just affect the border in Table toolbar. Your concern seems valid, we need diagonal variant also for Table Properties (In reply to Heiko Tietze from comment #7) > Guess it's solved with the patch. No, beside above reason, I have to make sure also that all themes already support this request
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/80a1c6ea4771cd9620addde2640d3c4d6276a5de elementary tdf#143300 add diagonal border line icons It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It would be nice to have a good title which summarizes the problem. 10.9 https://www.kitchenremodelhawaii.com/ should be obsolete as 10.10 is the minimum for installation of LO as of today.
Perfect, I will give the new version a try. https://www.towingwinnipeg.com/
@Rizal Muttaqin: we can add "fr015.*" -> for criss-cross border. as @Heiko Tietze suggested here: https://gerrit.libreoffice.org/c/core/+/118951 , I implemented criss-cross border UI with the last patchset. since criss-cross border doesn't exist in icons start with "fr*", I used "svx/res/pr06.png" for now. (but it doesn't fit very well in the box. when the criss-cross border becomes available, then I'll submit a new commit for the correct icon asap) What do you think? Thanks.
(In reply to Bayram Çiçek from comment #13) > @Rizal Muttaqin: > > we can add "fr015.*" -> for criss-cross border. > > as @Heiko Tietze suggested here: > https://gerrit.libreoffice.org/c/core/+/118951 , I implemented criss-cross > border UI with the last patchset. > > since criss-cross border doesn't exist in icons start with "fr*", I used > "svx/res/pr06.png" for now. (but it doesn't fit very well in the box. when > the criss-cross border becomes available, then I'll submit a new commit for > the correct icon asap) > > What do you think? > Thanks. https://gerrit.libreoffice.org/c/core/+/120862 Here the patch for Colibre.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ddf2e96b83fc28ba6ae3f204f6eba7972c7d2f13 Colibre: tdf#143300 add criss-cross border It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/83f5c19ae01c29bd95f605c0cf8ceb00cd1fb222 Breeze: tdf#143300 add criss-cross border It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3ee22d95d3e1e9ce1d2ff8311e51d600179370f9 elementary: tdf#143300 add criss-cross border It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d5d97d251f779fd78490ab7723a134dda1a11960 Sukapura: tdf#143300 add diagonal border It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1044496d10f2dc5097324dd8857bc6969ac013dc Karasa Jaga: tdf#143300 add diagonal border It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/282b2d8bfd6fb16f58fb177910427b031dc80066 Sifr: tdf#143300 add diagonal border It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I don't want to write everything in the blog post here because it's too long), just want to point out: All selected objects store in rMrkList list: const SdrMarkList &rMrkList = pDView->GetMarkedObjectList(); http://www-look-4.com/ Output of SAL_DEBUG( rMrkList.GetMarkDescription() ); (in SwFEShell::SelectObj): For shapes: "shapes" For 2+ shapes: "2 shapes" For draw images: "Image with transparency" For text box: "Text Frame" For raster images: "[Drawing object]" (defined as #define STR_ObjNameSingulNONE) http://www.compilatori.com/ rMrkList.GetMarkCount(); always increases by 1 when selecting drawing objects via SHIFT+CLICK. But always gives 1 when selecting raster images because pOldSelFly = ::GetFlyFromMarked( &rMrkList, this ); always return an address and this causes rMrkList doesn’t add the second selected raster image to itself and do unmark it. (if we force rMrkList to add raster images to itself by removing the pDView->UnmarkAll() line, this time, debugging warns "warn: /*...*/ frame is not accessible." ) http://www.wearelondonmade.com/ I don't understand why images handled different in Writer and Draw/Calc/Impress. IMHO, should we get rid of writer-images and convert them into drawing objects as like in the Draw? Otherwise, from my point of view, it seems a bit complicated to group raster images and raster&shapes. What do you think? http://www.jopspeech.com/ I don't want to write everything in the blog post here because it's too long), just want to point out: All selected objects store in rMrkList list: const SdrMarkList &rMrkList = pDView->GetMarkedObjectList(); Output of SAL_DEBUG( rMrkList.GetMarkDescription() ); (in SwFEShell::SelectObj): http://joerg.li/ For shapes: "shapes" For 2+ shapes: "2 shapes" For draw images: "Image with transparency" For text box: "Text Frame" For raster images: "[Drawing object]" (defined as #define STR_ObjNameSingulNONE) http://connstr.net/ rMrkList.GetMarkCount(); always increases by 1 when selecting drawing objects via SHIFT+CLICK. But always gives 1 when selecting raster images because pOldSelFly = ::GetFlyFromMarked( &rMrkList, this ); always return an address and this causes rMrkList doesn’t add the second selected raster image to itself and do unmark it. http://embermanchester.uk/ (if we force rMrkList to add raster images to itself by removing the pDView->UnmarkAll() line, this time, debugging warns "warn: /*...*/ frame is not accessible." ) I don't understand why images handled different in Writer and Draw/Calc/Impress. http://www.slipstone.co.uk/ IMHO, should we get rid of writer-images and convert them into drawing objects as like in the Draw? Otherwise, from my point of view, it seems a bit complicated to group raster images and raster&shapes. What do you think? I don't want to write everything in the blog post here because it's too long), just want to point out: http://www.logoarts.co.uk/ All selected objects store in rMrkList list: const SdrMarkList &rMrkList = pDView->GetMarkedObjectList(); Output of SAL_DEBUG( rMrkList.GetMarkDescription() ); (in SwFEShell::SelectObj): For shapes: "shapes" http://www.acpirateradio.co.uk/ For 2+ shapes: "2 shapes" For draw images: "Image with transparency" For text box: "Text Frame" For raster images: "[Drawing object]" (defined as #define STR_ObjNameSingulNONE) rMrkList.GetMarkCount(); https://waytowhatsnext.com/ always increases by 1 when selecting drawing objects via SHIFT+CLICK. But always gives 1 when selecting raster images because pOldSelFly = ::GetFlyFromMarked( &rMrkList, this ); always return an address and this causes rMrkList doesn’t add the second selected raster image to itself and do unmark it. (if we force rMrkList to add raster images to itself by removing the pDView->UnmarkAll() https://www.webb-dev.co.uk/ line, this time, debugging warns "warn: /*...*/ frame is not accessible." ) I don't understand why images handled different in Writer and Draw/Calc/Impress. IMHO, should we get rid of writer-images http://www.iu-bloomington.com/ and convert them into drawing objects as like in the Draw? Otherwise, from my point of view, it seems a bit complicated to group raster images and raster&shapes. What do you think?
jasa optimasi https://seohandal.id
Writer needs 2 new icons for diagonal left and diagonal right borders. These icons are needed for https://bugs.documentfoundation.org/show_bug.cgi?id=51665 . https://seohandal.id is a great one.
I am going to need to try this code to update the design of my flooring site. https://www.computerrepairelgin.com/
(In reply to flooringelgin from comment #24) > I am going to need to try this code to update the design of my flooring > site. https://www.flooringelgin.com/
Verified fixed in: Version: 7.3.0.1 / LibreOffice Community Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded However, the buttons still have no effect, which I assume is what is tracked in bug 51665 Adding buttons to add diagonal borders, but not having diagonal borders implemented, does bump up the priority of bug 51665 in my opinion. I see that it is currently set to a "high" priority enhancement, which seems fair.
please see the comments at Bug 146407. (the suggestion is to hide diagonal border icons for Writer - until the feature is implemented.)