Created attachment 173718 [details] Image showing the problem This is a follow-up to Bug 141566. Dark mode in the Basic Editor is working alright in LO 7.2 beta 1. However, the row numbers that appear to the left side of the editor are still black with a dark background (see attached ODG image). I suggest using the color #62666B - rgb(98, 102, 107). If someone can provide a code pointer, I can try to fix it. System Info: Version: 7.2.0.1 / LibreOffice Community Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc CPU threads: 16; OS: Linux 5.11; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded
Heiko, maybe you can provide a code pointer for this?
Changing the background color in basctl/source/baside/linenumberwindow.cxx to COL_RED make the background red. Simply doing SetTextColor(COL_RED); is not working but perhaps you can use this as start point. The color is taken from tools > options > app colors: Custom Colors (the top-most section) > Font color (set to Automatic). But I'd be afraid of touching this - and actually expect it to follow the system theme.
Created attachment 174243 [details] Dark theme on windows, so I cannot provide a patch, since I cannot check the outcome You may add const StyleSettings& rStyleSettings = GetSettings().GetStyleSettings(); // Adjust color to your needs, there are a lot of TextColor fields in the settings rRenderContext.SetTextColor(rStyleSettings.GetFieldTextColor()); https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/linenumberwindow.cxx?r=6da61d5f#80
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f0334d62da608e140073e8831fdbbd0b5e4b1e39 Resolves tdf#143462 - Fixes black row number on dark backgroud in Basic IDE It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.