Bug 143550 - "Glue Points" should be renamed consistently "Gluepoints" (comment 3)
Summary: "Glue Points" should be renamed consistently "Gluepoints" (comment 3)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Ross Johnson
URL:
Whiteboard: target:7.3.0
Keywords: difficultyBeginner, easyHack, skillUI, topicUI
Depends on:
Blocks:
 
Reported: 2021-07-26 14:59 UTC by sophie
Modified: 2021-09-17 10:54 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sophie 2021-07-26 14:59:30 UTC
String location:
https://git.libreoffice.org/core/+/master/officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu#820

For consistency with other UI elements called Blue Point, the toolbar should be named the same.
Comment 1 Julien Nabet 2021-07-26 16:21:07 UTC
Heiko/Xisco:
here are the result of some searching:
julien@debianamd:~/lo/libreoffice$ git grep -in '>gluepoints<'
officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu:820:          <value xml:lang="en-US">Gluepoints</value>
julien@debianamd:~/lo/libreoffice$ git grep -in '>glue points<'
officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu:533:          <value xml:lang="en-US">Glue Points</value>
julien@debianamd:~/lo/libreoffice$ git grep -in '>glue point<'
officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu:70:          <value xml:lang="en-US">Glue Point</value>
officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu:70:          <value xml:lang="en-US">Glue Point</value>
julien@debianamd:~/lo/libreoffice$ git grep -in '>gluepoint<'
offapi/com/sun/star/drawing/GluePoint.idl:55:    /** The alignment of a <code>GluePoint</code> defines how the position of

I let you take a look at the result with
git grep -in '"gluepoints"', git grep -in '"gluepoint"'

I must recognize, cleaning this part should help and may even tackle some obscure slight bugs :-)

(about "Blue point", I understand it makes think about summer vacations but I don't think it would be accepted :-p)
Comment 2 Heiko Tietze 2021-08-23 09:37:21 UTC
Makes sense to rename the toolbar. If not "blue" :-)

aProp.Name = "GluePoints" (and similar)- that is likely the internal variable name.
Comment 3 Ross Johnson 2021-09-15 07:42:18 UTC
There is also specific reference to the toolbar in the help repository:

source/text/simpress/guide/gluepoints.xhp:51:<paragraph role="paragraph" id="par_id0919200803041160" xml-lang="en-US">Click the <emph>Insert Glue Point</emph> icon on the Gluepoints toolbar.</paragraph>

There is detailed advice here: https://www.merriam-webster.com/words-at-play/spelling-using-compound-words-guide/open-or-close-the-compound

Also from Merriam-Webster:
"Although the styling that ultimately takes hold for a compound may be determined by nothing more than editorial preference, there is one pattern that often holds true as new compounds become entrenched in English. Compound nouns are usually written as one word, compound verbs are generally written as two, and compound adjectives are very often written with a hyphen."

I could not find any advice on when it would be appropriate for closed compounds to revert to open compounds, eg, such as when they appear as a label in a menu etc.

"Gluepoint" is an example of what is called a compound word (duh). In this case it is the noun "point" preceded by the modifying verb "glue", which together form a noun.

Further searches for occurrences:

"gluepoint" and "gluepoints" appear at least this many times in sentences in the help repository:

$ git grep -c ' gluepoint[s]* '
source/text/simpress/02/10030200.xhp:9
source/text/simpress/02/10100000.xhp:30
source/text/simpress/guide/gluepoints.xhp:3

"glue point" or "glue points" appear at least this many times in sentences in the help repository:
 
$ git grep -c ' glue point[s]* '
source/text/sdraw/main0210.xhp:1
source/text/sdraw/main0503.xhp:1
source/text/sdraw/main_edit.xhp:1
source/text/simpress/02/13010000.xhp:1
source/text/simpress/guide/gluepoints.xhp:2
source/text/simpress/main0210.xhp:1

With "Glue Point" or "Glue Points" appearing at least this many times in the help repository:

$ git grep -c 'Glue Point[s]*'
source/text/sdraw/main0210.xhp:1
source/text/simpress/00/00000402.xhp:1
source/text/simpress/02/10030200.xhp:16
source/text/simpress/02/13010000.xhp:4
source/text/simpress/guide/gluepoints.xhp:6
source/text/simpress/main0210.xhp:1
source/text/simpress/main_edit.xhp:2

As in:

source/text/simpress/02/10030200.xhp:32:<paragraph role="heading" id="hd_id3149948" xml-lang="en-US" level="1"><variable id="gluepointsbar"><link href="text/simpress/02/10030200.xhp">Glue Points Bar</link>

The capitalisation looks particularly awkward so I would argue the above should be "Gluepoints Bar" as in the following:

source/text/simpress/guide/gluepoints.xhp:25:<title id="tit" xml-lang="en-US">Using Gluepoints</title>

In general help body text the closed compound form predominates. Where it appears in the open form it is mostly capitalised, eg, in headings.
Comment 4 Heiko Tietze 2021-09-15 07:55:01 UTC
(In reply to Ross Johnson from comment #3)
> Compound nouns are usually written as one word, compound verbs are generally
> written as two, and compound adjectives are very often written with a
> hyphen."
> ....
> "Gluepoint" is an example of what is called a compound word (duh).

Thanks for looking into it. Native speakers are the best to handle questions like this (being German I feel home with compound words).
Comment 5 Ross Johnson 2021-09-16 12:53:36 UTC
(In reply to Heiko Tietze from comment #4)
> (In reply to Ross Johnson from comment #3)
> > Compound nouns are usually written as one word, compound verbs are generally
> > written as two, and compound adjectives are very often written with a
> > hyphen."
> > ....
> > "Gluepoint" is an example of what is called a compound word (duh).
> 
> Thanks for looking into it. Native speakers are the best to handle questions
> like this (being German I feel home with compound words).

I've taken this issue and currently checking changes that would see "gluepointer" etc consistently appearing everywhere, rather than the other way round.
Comment 6 Ross Johnson 2021-09-17 07:17:11 UTC
Patches submitted to review for both core and help.
Comment 7 Commit Notification 2021-09-17 10:40:00 UTC
rocso committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/ee13bc67bf0a292b19985923536924f5ab1abd0b

tdf#143550 - make gluepoints terminology consistent
Comment 8 Commit Notification 2021-09-17 10:54:17 UTC
rocso committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4f7560240d8a9273fd5ecbc76e7ac054b3a6e4ae

tdf#143550 - use the term "gluepoints" consistently

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.