Open ODT attachment 169336 [details], mark image on 1st page and press Delete key. Crash from 7.2. Regression. Happens only with "Show outline-folding buttons" in Options-Writer-View. commit d267c44c1503c7f93a83d60d3ec4a2bb6a1278f2 Date: Fri May 14 06:18:42 2021 +0200 source 6b09276d157abada74e1a4989700139167207778 previous 6c8ca02c5935a800cff70f3c173319b454b63c41 author Jim Raykowski <raykowj@gmail.com> Sun Apr 18 23:00:38 2021 -0800 Outline folding experimental feature rehack
On pc Debian x86-64 with master sources updated today, I don't reproduce this with gen, kf5 or gtk3 rendering. I also enabled experimental features just to be sure, nothing too. On which env are you? Would it be possible you retrieve a stacktrace? (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information)
I have crash in Windows and Linux Mint 19 (based on Ubuntu 18.04) Gen and GTK3, also with LO 7.3+. Seems to be the same as in bug 142733, not all reproduce.
This is what I see on crash. Just obsolete if of no use. Fatal exception: Signal 6 Stack: /home/t/linux-64-7.3/instdir/program/libuno_sal.so.3(+0x14d34)[0x7f99015ced34] /home/t/linux-64-7.3/instdir/program/libuno_sal.so.3(+0x3fe06)[0x7f99015f9e06] /lib/x86_64-linux-gnu/libc.so.6(+0x3f040)[0x7f9900f27040] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7f9900f26fb7] /lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7f9900f28921] /home/t/linux-64-7.3/instdir/program/libvcllo.so(+0x8ba9bc)[0x7f98f95a29bc] /home/t/linux-64-7.3/instdir/program/libvcllo.so(_ZN11Application5AbortERKN3rtl8OUStringE+0xa2)[0x7f98f947cb42] /home/t/linux-64-7.3/instdir/program/libsofficeapp.so(+0x28096)[0x7f9901301096] /home/t/linux-64-7.3/instdir/program/libvcllo.so(+0x79ca48)[0x7f98f9484a48] /home/t/linux-64-7.3/instdir/program/libuno_sal.so.3(+0x17c82)[0x7f99015d1c82] /home/t/linux-64-7.3/instdir/program/libuno_sal.so.3(+0x3fccf)[0x7f99015f9ccf] /lib/x86_64-linux-gnu/libc.so.6(+0x3f040)[0x7f9900f27040] /home/t/linux-64-7.3/instdir/program/../program/libswlo.so(_ZN10SwTextNode28GetAttrOutlineContentVisibleERb+0x1d)[0x7f98bf4a7dbd] /home/t/linux-64-7.3/instdir/program/../program/libswlo.so(_ZN11SwBaseShell10ExecDeleteER10SfxRequest+0x2c4)[0x7f98bf942894] /home/t/linux-64-7.3/instdir/program/libsfxlo.so(+0x1b7fcf)[0x7f98fc55ffcf] /home/t/linux-64-7.3/instdir/program/libsfxlo.so(_ZN13SfxDispatcher8Execute_ER8SfxShellRK7SfxSlotR10SfxRequest11SfxCallMode+0xe6)[0x7f98fc564126] /home/t/linux-64-7.3/instdir/program/libsfxlo.so(+0x1b39d3)[0x7f98fc55b9d3] /home/t/linux-64-7.3/instdir/program/libsfxlo.so(+0x20e7b3)[0x7f98fc5b67b3] /home/t/linux-64-7.3/instdir/program/libsfxlo.so(+0x20ec70)[0x7f98fc5b6c70] /home/t/linux-64-7.3/instdir/program/libsvtlo.so(+0x17f8d9)[0x7f98fac8d8d9] /home/t/linux-64-7.3/instdir/program/libvcllo.so(+0x4a1fb7)[0x7f98f9189fb7] /home/t/linux-64-7.3/instdir/program/libvcllo.so(_ZN16SalUserEventList18DispatchUserEventsEb+0x162)[0x7f98f943de22] /home/t/linux-64-7.3/instdir/program/libvclplug_gtk3lo.so(+0xe1ba9)[0x7f98e6c97ba9] /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_dispatch+0x155)[0x7f98f18f13a5] /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x4c770)[0x7f98f18f1770] /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_iteration+0x2c)[0x7f98f18f17fc] /home/t/linux-64-7.3/instdir/program/libvclplug_gtk3lo.so(+0xe312c)[0x7f98e6c9912c] /home/t/linux-64-7.3/instdir/program/libvcllo.so(+0x7944d2)[0x7f98f947c4d2] /home/t/linux-64-7.3/instdir/program/libvcllo.so(_ZN11Application7ExecuteEv+0x45)[0x7f98f947e9b5] /home/t/linux-64-7.3/instdir/program/libsofficeapp.so(+0x2eeba)[0x7f9901307eba] /home/t/linux-64-7.3/instdir/program/libvcllo.so(_Z10ImplSVMainv+0x46)[0x7f98f9486456] /home/t/linux-64-7.3/instdir/program/libsofficeapp.so(soffice_main+0x125)[0x7f9901334fa5] /home/t/linux-64-7.3/instdir/program/soffice.bin[0x40066b] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7f9900f09bf7] /home/t/linux-64-7.3/instdir/program/soffice.bin[0x40069f]
Created attachment 173915 [details] gdb.trace for fileopen I tried to get backtrace in Linux, but debug crashes already on fileopen.
I tried to get a backtrace in Linux, but debug crashes already on file open. Seems to be the same as in bug 142733, not all reproduce. <a href="https://nergeticmodding.com/">gta 5 modded accounts </a>
(In reply to Timur from comment #4) > Created attachment 173915 [details] > gdb.trace for fileopen > > I tried to get backtrace in Linux, but debug crashes already on fileopen. When you see ?? you can continue by typing "c" until you see something else than ? or ??. I don't remember well but I think these are related with Java because of an obscure reason.
Created attachment 173940 [details] gdb.trace for crash on delete I didn't see anything, debug build crashed when opening this ODT. But I turned off Java and it opens it . Here is gdb.trace for crash on delete.
Created attachment 173941 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. Sorry Timur, I had forgotten to do this: - in Tools/Options/Advanced Check "Enable experimental features" - restart LO - in Tools/Options/Writer/View Check "Show outline-folding buttons"
Jim: I noticed 2 things 1) about the crash itself, it crashes because of this line: 207 aIdx.GetNode().GetTextNode()->GetAttrOutlineContentVisible(bVisible); In the case of the bugtracker aIdx.GetNode() isn't a text node, it's a graph node. 2) I don't understand the adding of returns in https://cgit.freedesktop.org/libreoffice/core/commit/?id=6b09276d157abada74e1a4989700139167207778 I mean, in case we enter the return instructions, we never execute the instructions after the switch: 273 rReq.Done(); 274 275 //#i42732# - notify the edit window that from now on we do not use the input language 276 rTmpEditWin.SetUseInputLanguage( false ); Is it expected?
(In reply to Julien Nabet from comment #9) > Jim: I noticed 2 things > 1) about the crash itself, it crashes because of this line: > 207 aIdx.GetNode().GetTextNode()->GetAttrOutlineContentVisible(bVisible); > In the case of the bugtracker aIdx.GetNode() isn't a text node, it's a graph > node. > right, need to make sure the node is actually a text node. > 2) I don't understand the adding of returns in > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=6b09276d157abada74e1a4989700139167207778 > I mean, in case we enter the return instructions, we never execute the > instructions after the switch: > > 273 rReq.Done(); > 274 > 275 //#i42732# - notify the edit window that from now on we do not use > the input language > 276 rTmpEditWin.SetUseInputLanguage( false ); > > Is it expected? right again, returns should be breaks
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0ff5eb97b89f89e770d4397bf76f24fb7cd76b57 tdf#143577 check node is a text node before use as such It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
experimental feature, I don't think this should be high/major
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/d3f5f1b0068b8ab57f7aae9588cc0cff4af1db54 tdf#143577 check node is a text node before use as such It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I confirm there's no more crash. But I suspect on a regression with attachment from bug 142733. Instead of 64 pages, it opens thousands pages, regardless of "Show outline-folding buttons". I cannot confirm now without today's bibisect, but Jim please check.
Sorry, that's different, present before, I'll check in other bug. I set this one as Verified.