Bug 143646 - UI: Minimum size of the Chart sidebar creates a horizontal scrollbar
Summary: UI: Minimum size of the Chart sidebar creates a horizontal scrollbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.3.0 target:7.2.2
Keywords:
Depends on:
Blocks: Sidebar-UI-UX
  Show dependency treegraph
 
Reported: 2021-07-31 17:09 UTC by Telesto
Modified: 2021-11-15 11:05 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Screencast (607.53 KB, video/mp4)
2021-08-04 08:50 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-07-31 17:09:46 UTC
Description:
Minimum size of the Chart sidebar creates a horizontal scrollbar

Steps to Reproduce:
1. Open Writer
2. Press insert chart
3. Double click the chart.. so the sidebar gets activated.. downsize it to mimimum

Actual Results:
There is a scrollbar

Expected Results:
It shouldn't be the case


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Dmitrii A 2021-08-02 05:07:06 UTC
No repro in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ac80ec817eb07c77a51bc0729985a473c734182e
CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL
Comment 2 Nina_Shtygailo 2021-08-04 06:22:36 UTC
Is it possible to attach a video or screenshots of the problem?
When I double-click on the chart, the "Chart Wall" window opens.
Comment 3 Telesto 2021-08-04 08:50:26 UTC
Created attachment 174061 [details]
Screencast
Comment 4 Nina_Shtygailo 2021-08-04 09:01:04 UTC
video does not play
Comment 5 Nina_Shtygailo 2021-08-04 09:09:36 UTC
downloaded, now I'll take a look
Comment 6 Nina_Shtygailo 2021-08-04 10:27:16 UTC
no repro in

Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: CL
Comment 7 Heiko Tietze 2021-08-19 08:17:30 UTC
Neither with Version: 7.1.5.2 VCL: kf5
Comment 8 V Stuart Foote 2021-08-19 13:28:53 UTC
This is more generic. May be Windows only. Has to do with the UI trigger to expose the horiz scroll bar as the Sidebar deck reaches its minimum width.

'Minimum width' for the Sidebar Deck per content panel should be the GTK packing with all controls exposed.  The horiz scroll bar should not appear. 

Only when controls start to be hidden, (as for work on bug 140360) after setting expert config 'MinimumWidth' boolean false, should we see the horiz scroll where it is needed.

Exposed too soon it is an annoyance--and hides SB deck content.

=-testing-=

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5aac78e5fb241050a86714687e9ff8804588ae3c
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 9 Caolán McNamara 2021-08-30 15:17:13 UTC
I think its a 2 pixel difference, something is probably missing factoring in a 1 pixel margin/border.
Comment 10 Caolán McNamara 2021-09-01 11:48:59 UTC
Comment #9 really refers to bug 142458. This one seems different and is triggered by the "chart type" panel in the deck
Comment 11 Commit Notification 2021-09-01 14:33:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7faa086071afe2638d371818d90cecc820e602ef

Resolves: tdf#143646 move the border from the outer grid to the inner one

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2021-09-02 14:55:47 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/de834f98e22e660b186cb4b27b228d189c194ee7

Resolves: tdf#143646 move the border from the outer grid to the inner one

It will be available in 7.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Caolán McNamara 2021-09-02 20:05:30 UTC
That seems to work, the chart panel is a bit flaky compared to the others as its something of a special case, but this specific issue seems to be fixed now.