Bug 143760 - FILESAVE DOCX user change from contour wrap to "wrap off" is not respected
Summary: FILESAVE DOCX user change from contour wrap to "wrap off" is not respected
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: DOCX-Anchor-and-Text-Wrap
  Show dependency tree / graph
 
Reported: 2021-08-06 14:03 UTC by Regina Henschel
Modified: 2021-08-13 18:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
File to reproduce the problem (19.15 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-08-06 14:03 UTC, Regina Henschel 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2021-08-06 14:03:24 UTC 
Created attachment 174112 [details]
File to reproduce the problem

Open attached file. It has a contour wrap on the shape in Word and shows contour wrap in LO too.
Click the shape and change its wrap type to "wrap off".
Save the document in docx format.
Reopen.
Error: The wrap is a contour wrap as in the beginning. The new wrap type "wrap off" has not been saved.

Reason is a wrong order in the implementation. It currently first checks for a wrap polygon in the InteropGrabBag before evaluating the current wrap type.
Comment 1 Regina Henschel 2021-08-06 14:05:01 UTC 
I'm currently working on improving the export of wrap settings to docx. I will fix it together with the other problems. I have reported it to have a bug number for this error.
Comment 2 raal 2021-08-07 16:44:31 UTC 
confir Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 3 Regina Henschel 2021-08-13 18:07:59 UTC 
The wrong wrap is fixed with
https://git.libreoffice.org/core/commit/61ef73bb9e06ac7325abc26698314d7e35c164cc
tdf#143432 and more, improve wrap contour export