Opening a shapes Position and Size dialog sets modified status even if there were no changes made. Steps to reproduce: 1. Open attachment 174144 [details] from bug 143778 2. Right click on the rectangle, select Position and Size 3. Close the dialog with Cancel Actual results: Document is in modified status. Expected results: Document should not be considered changed. LibreOffice details: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d1f1f546b212ecd651146addeb328806bb270d5f CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: CL Also in 5.1, but not yet in 5.0. Additional Information: Bibisected using bibisect-win32-5.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=eafd3ee3f01bceef0eb3327be3139a8eee2a2b2e author Caolán McNamara <caolanm@redhat.com> 2015-11-05 13:42:13 +0000 committer Caolán McNamara <caolanm@redhat.com> 2015-11-05 13:44:13 +0000 tdf#95210 SetHandleControllerPosition is busted wrt HandleFlags::REFX Adding CC to: Caolán McNamara
Status jump to modified as soon as the dialog Position and Size appears. Set to NEW. Best regards. JBF
The fox for this of https://gerrit.libreoffice.org/c/core/+/120550on its own won't be enough without the fix of https://gerrit.libreoffice.org/c/core/+/120548 also in place
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6dc23567639bebf18ceb8d9a3721228bffe14202 Resolves: tdf#143785 save/restore SdrModel::IsChanged It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fixed in trunk, backport to 7-2 and 7-1 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/53b534991b9eb516aac019a02b61d7b1dc9db28e Resolves: tdf#143785 save/restore SdrModel::IsChanged It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/c777efbcbc5bbc3c78b7c0176447adf25b1e697e Resolves: tdf#143785 save/restore SdrModel::IsChanged It will be available in 7.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi Caolán, the issue is still reproducible in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 615a340fcf05845397ea3c9917e2eadf074b4514 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded which includes your patch
does your build have both patches mentioned in comment #5 ? i.e. the additional patch of https://gerrit.libreoffice.org/c/core/+/120548
(In reply to Caolán McNamara from comment #8) > does your build have both patches mentioned in comment #5 ? i.e. the > additional patch of https://gerrit.libreoffice.org/c/core/+/120548 You are completely right, sorry for the noise. Verified in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5bdc7bb066928f90b5d8cce4d89c125915386cdf CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4297f40c6ab03701ffebf670cbf1186573ba6a15 tdf#143778, tdf#143785: sw: add UItest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.