Bug 143807 - FILEOPEN ODT->DOC/DOCX: Table height slightly larger compared to ODT (since 7.1)
Summary: FILEOPEN ODT->DOC/DOCX: Table height slightly larger compared to ODT (since 7.1)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx
Depends on:
Blocks: DOCX-Tables
  Show dependency treegraph
 
Reported: 2021-08-10 12:23 UTC by Telesto
Modified: 2023-06-08 16:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (77.01 KB, application/vnd.oasis.opendocument.text)
2021-08-10 12:23 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-08-10 12:23:34 UTC
Description:
FILEOPEN DOC/DOCX: Table height larger compared to ODT (since 7.1)

Steps to Reproduce:
1. Open the attached file
2. Save to DOCX
3. File reload
4. Open the ODT again
5. Switch back and forward between ODT/DOCX (notice the difference)

Actual Results:
Table height difference

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

and in
Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

not in
7.0
Comment 1 Telesto 2021-08-10 12:23:50 UTC
Created attachment 174177 [details]
Example file
Comment 2 raal 2021-08-10 19:19:00 UTC
Confirm in Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: c97bdca2d7abf30a99c45192b8f49c5bf76ca035
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 3 raal 2021-08-10 19:35:14 UTC
This seems to have begun at the below commit.
Adding Cc: to Michael Stahl ; Could you possibly take a look at this one?
Thanks
 9495f24f8b825bbff3c6a73cacd7e8ee5f359150 is the first bad commit
commit 9495f24f8b825bbff3c6a73cacd7e8ee5f359150
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Sep 25 01:45:31 2020 +0200

    source 38aa699f265c17548769aaa4f20e1ae35d18f202

https://git.libreoffice.org/core/+/38aa699f265c17548769aaa4f20e1ae35d18f202
   tdf#134782 sw: split AddParaSpacingToTableCells flag in 2
Comment 4 Timur 2021-08-11 11:50:53 UTC
Please set Importance. This is Minor at best, low to lowest.
Comment 5 Michael Stahl (allotropia) 2021-08-11 11:55:22 UTC
so if i revert the commit in comment #3, nothing changes.

if i try the latest libreoffice-7-0, -6-4 still the same result.

but with libreoffice-6-3 we get the same looks when loading the exported DOCX as when loading the ODT.

however, it turns out that Word 2013 shows the DOCX exported by LO 6.3 differently than LO 6.3, and in the same way as current LO => LO 6.3 DOCX import is wrong

so it looks like this never actually worked => removing regression

the ODT file has:

      <config:config-item config:name="AddParaSpacingToTableCells" config:type="boolean">true</config:config-item>
      <config:config-item config:name="AddParaLineSpacingToTableCells" config:type="boolean">false</config:config-item>

AFAIK Word doesn't support such a mode directly.

there is some code in MSWordExportBase::OutputTextNode() that checks the spacing setting and clears a Lower-space ... but the paragraphs in the table don't have a RES_UL_SPACE so the test is skipped and adding ADD_PARA_LINE_SPACING_TO_TABLE_CELLS there doesn't help.

sw/source/filter/ww8/wrtw8nds.cxx:                    if (!m_rDoc.getIDocumentSettingAccess().get(DocumentSettingId::ADD_PARA_SPACING_TO_TABLE_CELLS))

not sure what to do about this but it doesn't look obvious.
Comment 6 Telesto 2021-08-11 13:59:24 UTC
(In reply to Timur from comment #4)
> Please set Importance. This is Minor at best, low to lowest.

Well page flow of documents on export is kind of important (at least to me). If you have a nice layout in ODT, but this this being screwed on export.

The big question is more how likely is this to occur. I get the impression that this isn't regular, based on comment 5. But well that wasn't something to be known, before you demoted the bug.