Bug 143834 - WORD COUNT: When "Show Track Changes" enabled show the actual number of words/characters without TC as if it was printed (see comment 3)
Summary: WORD COUNT: When "Show Track Changes" enabled show the actual number of words...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.5.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Track-Changes Word-Count
  Show dependency treegraph
 
Reported: 2021-08-12 09:12 UTC by f.zit
Modified: 2023-09-11 11:33 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description f.zit 2021-08-12 09:12:35 UTC
Version: 7.1.5.2 / LibreOffice Community
Build ID: 10(Build:2)
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.utf8); UI: en-US
7.1.5-2
Calc: threaded

I hope this is not a duplicate. I found a few (fixed) bugs related to erroneous word count (WC) and tracked changes, but those did not match my observations:
When changes are tracked, deleted words are not counted (as expected). However, I experience erroneous word counting when a whole paragraph is deleted:


1) New document
2) Insert this content:
w1
w2 w3
w4 w5
3) Select all -> WC 5
4) Activate track changes
5) Delete the second paragraph. Hide the tracked changes; the document shows:
w1
w4 w5
6) Select all -> WC 5 (Expectation: WC decreased by 2. Behavior: WC unchanged.)
7) Delete " w5"
8) Select all -> WC 4 (Expectation: WC decreased by 1. Behavior: WC decreased by 1.)
Comment 1 Dieter 2021-08-28 10:14:07 UTC
I confirm it with

Version: 7.2.0.3 (x64) / LibreOffice Community
Build ID: 2a7ea282da28d665a7dc086360567b4aea27bf08
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

I can't see a consinstence behaviour here and I also think, that word count is completely useless in such a case.

Second example:
1. Write a sentence with five words
2. Enable record and view track changes
3. Delete that sentence and write a new sentence with three words => WC 8 words
The display shows eight words, but for the author, this is a completely irrelevant information. Either the text has three words (if you accept changes) or it has five word (if you reject changes)

=> NEW

I don't know, if there is a consenus about the expected behaviour, but we chould have one. Personally I can sse two possibilities
a) Word Count has always the result of the document without showing track changes (that's also the expecatation from bug reporter)
b) Word count is disabled, if document shows track changes

I would prefer solution b), because it obvious, that you can't count the words with visible track changes in a helpful way.

cc: Design-Team for further input and decision.
Comment 2 Heiko Tietze 2021-08-30 13:14:31 UTC
Reported and fixed (Muhammet) with a unit test (Caolan) in bug 46757. 

(In reply to Dieter from comment #1)
> a) Word Count has always the result of the document without showing track
> changes (that's also the expecatation from bug reporter)
> b) Word count is disabled, if document shows track changes

And c) Measurement with and without TC, see also bug 123083.
Comment 3 Heiko Tietze 2021-09-06 08:57:17 UTC
No further opinion (and I don't want to keep it on the agenda for the design meeting). So my take is a) respectively WYPIWYG: Show the actual number of words/characters without TC as if it was printed.
Comment 4 Dieter 2021-09-12 09:47:43 UTC
(In reply to Heiko Tietze from comment #3)
> No further opinion (and I don't want to keep it on the agenda for the design
> meeting). So my take is a) respectively WYPIWYG: Show the actual number of
> words/characters without TC as if it was printed.

O. K. for me (I changed bug summary).
Comment 5 Sophie Sipasseuth 2023-09-05 12:38:02 UTC
No repro with:

Version: 7.0.0.0.alpha1+ (x64)
Build ID: 574c57090642347980d2395e1e183cc7b5c171ad
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: threaded

Version: 7.1.0.0.alpha1+ (x64)
Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: threaded

Repro with:

Version: 7.1.8.0.0+ (x64) / LibreOffice Community
Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: threaded

But no repro with:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: df3b95a39472e18ea8acdaae447b7176e37a9256
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

The bug seems resolved in the last version of LibreOffice.
Comment 6 Buovjaga 2023-09-11 11:33:50 UTC
Note: while testing I was looking at word count in the status bar, but Tools - Word Count works the same way.

(In reply to f.zit from comment #0)
> 1) New document
> 2) Insert this content:
> w1
> w2 w3
> w4 w5
> 3) Select all -> WC 5
> 4) Activate track changes
> 5) Delete the second paragraph. Hide the tracked changes; the document shows:
> w1
> w4 w5
> 6) Select all -> WC 5 (Expectation: WC decreased by 2. Behavior: WC
> unchanged.)

In the latest version this step gives the expected result of 3 words.

I bibisected this change with Linux 7.6 repo to 9788a565b3241d1bd62394b9e29c322361d05f80

It seems to be due to this added line in sw/source/uibase/wrtsh/select.cxx:

GetView().GetViewFrame().GetBindings().Update(FN_STAT_SELMODE); // make selection mode control icon update immediately

> 7) Delete " w5"
> 8) Select all -> WC 4 (Expectation: WC decreased by 1. Behavior: WC
> decreased by 1.)

In the latest version, this gives the unexpected result of 4 words.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8c982bf86ff9ca5a4ed86505ec1133cc183f1b58
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded