Bug 144005 - Assertion failure when moving a media shape in debug build
Summary: Assertion failure when moving a media shape in debug build
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: haveBacktrace
Depends on:
Blocks: Crash-Assert
  Show dependency tree / graph
 
Reported: 2021-08-22 14:23 UTC by Regina Henschel
Modified: 2022-05-23 10:03 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
MS VS call stack (3.86 KB, text/plain)
2021-08-22 14:23 UTC, Regina Henschel 		Details
bt with debug symbols (8.70 KB, text/plain)
2021-08-22 20:50 UTC, Julien Nabet 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2021-08-22 14:23:30 UTC 
Created attachment 174476 [details]
MS VS call stack

Start a text document. Insert a sound from the Gallery. Move the inserted media-shape. ==> Crash

The crash happens in sw/source/core/undo/unattr.cxx in
SwUndoFormatAttr::SwUndoFormatAttr

The parameter rChgFormat is empty and therefore
assert(m_sFormatName.getLength());
fails.
Crash message is
Unhandled exception at 0x00007FFC6573286E (ucrtbase.dll) in soffice.bin: Fatal program exit requested.

The crash happens in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bae2fbfd341b2cb5e5053c7977176f68b5d658dd
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: threaded

That is a debug build.
Comment 1 Roman Kuznetsov 2021-08-22 20:05:46 UTC 
No crash in daily build

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL
Comment 2 Julien Nabet 2021-08-22 20:50:02 UTC 
Created attachment 174480 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this and had an assertion.
Comment 3 Julien Nabet 2021-08-22 20:54:05 UTC 
Assert instructions added with:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=d39651a69d789522b2faffd01879db25354b9a22
"author	Vasily Melenchuk <vasily.melenchuk@cib.de>	2020-08-27 15:13:08 +0300
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2020-09-15 11:04:25 +0200
commit d39651a69d789522b2faffd01879db25354b9a22 (patch)
tree e3852c43ba713ed8d6d8305aeaa8cd6b35dfa148
parent 315919306c7b6e95db6a280c4aa8d2203970e292 (diff)
sw: additional asserts/warns to diagnose empty style names
Since undo/redo is using format name instead of old approach
with pointers (which can point to invalid/removed style) it
is a problem when we trying to use any style without name:
it will be not resolved and undo/redo will work
incorrectly: it can apply invalid attributes or apply style
to another random objects."

Vasily/Thorsten/Michael: thought you might be interested in this one.