Bug 144190 - _Left Align and _Right Align should be Align _Left and Align _Right
Summary: _Left Align and _Right Align should be Align _Left and Align _Right
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Po-Yen Huang
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on: 145092
Blocks:
  Show dependency treegraph
 
Reported: 2021-08-30 15:30 UTC by sophie
Modified: 2021-12-29 01:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Toolbar in question (24.72 KB, image/png)
2021-10-12 06:15 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Regina Henschel 2021-10-07 23:56:33 UTC
The settings "Left Align", "Center", "Right Align" and "Word justify" in the drop-down "Fontwork Alignment" are bound to the "Anchor" setting in the 'Text Attributes' dialog. Thereby only the vertical middle options are supported (at least for horizontal writing mode, don't now for top-bottom writing mode).

When you set the anchor to the option "middle right" in the 'Text Attributes', then the "Fontwork Alignment" will be "Right Align" and vis-a-vis. The option "Center" belongs to option "middle/center disabled 'Full width" and the option "Word justify" belongs to option "middle/center with checked 'Full width'".

"Word justify" rendering is broken, see bug 37808.

Therefore I'm not sure whether "align" is the correct term at all.
Comment 2 Heiko Tietze 2021-10-12 06:15:26 UTC
Created attachment 175681 [details]
Toolbar in question

In fact you can align the text right/left/center or stretch it (only per click on the icon not the label in kf5, v7.2). The base point in the Position & Size dialog has no effect and actually is not accepted at all.
Comment 3 Heiko Tietze 2021-10-21 12:59:04 UTC
The topic was on the agenda of the design meeting but didn't receive further input. 

Bug 145092 suggests to remove Word Justify. And whether "Align Left" or "Left Align" makes not much difference but saves the l10n team some time. So we should do it.

svx/uiconfig/ui/fontworkalignmentcontrol.ui
Comment 4 Po-Yen Huang 2021-12-27 03:02:54 UTC
I pushed a fix to gerrit, please review it :-)
https://gerrit.libreoffice.org/c/core/+/127540
Comment 5 Commit Notification 2021-12-29 00:53:17 UTC
Jeff Huang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8578add8775a258c79bd32f52a704ab2173bea47

tdf#144190 Change _Left Align and _Right Align to Align _Left and Align _Right

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.