Bug 144364 - Autotext (text only) with placeholder not correctly displayed
Summary: Autotext (text only) with placeholder not correctly displayed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.6.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-09-07 20:01 UTC by Laurent Balland
Modified: 2021-12-22 09:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Balland 2021-09-07 20:01:31 UTC
Description:
Some bundled autotexts are text only and contain a placeholder. After inserting autotext, text of the placeholder remains unchanged

Steps to Reproduce:
1. Set UI language to en-US 
2. Create a new Writer document
3. Type a name of an autotext (text only) with a placeholder, like AR
4. Hit F3

Actual Results:
Text of Autotext is inserted, but placeholder code remains unchanged. In the example given:
We hereby acknowledge the receipt of your letter of <placeholder:"November 21, 2004":"Click placeholder and overwrite">.

Expected Results:
Placeholder should be replaced by its value:
We hereby acknowledge the receipt of your letter of <November 21, 2004>.


Reproducible: Always


User Profile Reset: No



Additional Info:
Confirmed with Version: 7.0.6.2
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (fr_FR.UTF-8); UI: en-US
Calc: threaded

NOT confirmed with Version: 6.4.7.2
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-US (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Justin L 2021-09-08 05:12:13 UTC
Repro 7.3+. Used bibisect-linux-64-7.0 to identify the regression came from
author	Noel Grandin on 2020-01-09 14:03:18 +0100
commit fd6feb4f538b0c5c9061529ff002be9f62a7239a
    Use FastParser in SwXMLTextBlocks
    the underlying SvXMLImport subclass already has a FastParser inside it

https://cgit.freedesktop.org/libreoffice/core/commit/?id=fd6feb4f538b0c5c9061529ff002be9f62a7239a

confirmed by reverting fd6feb4f538b0c5c9061529ff002be9f62a7239a and re-including what was removed in commit b6222a90f1d0ae800dc5362ebc9b5b354ba873b1.

CC: Noel
Comment 2 Commit Notification 2021-12-18 05:46:47 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1addd8c104f6ad390bdd0ca61cd5ce97b55ce218

tdf#144364 sw: Revert "Use FastParser in SwXMLTextBlocks"

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2021-12-20 07:33:41 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/97783676a85ea49aee856b5bd7193a4911856946

tdf#144364 sw: Revert "Use FastParser in SwXMLTextBlocks"

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2021-12-20 11:35:39 UTC
I guess we can close this issue.
@Justin, thanks for taking care of it!!
Comment 5 Commit Notification 2021-12-20 12:54:48 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/d8cf8482ae5ed72dc969d9adb47c113c442452be

tdf#144364 sw: Revert "Use FastParser in SwXMLTextBlocks"

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-12-22 09:15:55 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-5":

https://git.libreoffice.org/core/commit/156f2e3bac9ba2cfe517ea14e7cce961bd0e7ceb

tdf#144364 sw: Revert "Use FastParser in SwXMLTextBlocks"

It will be available in 7.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.