Steps to Reproduce: 1. Create a presentation in Impress 2. Save to ODP, select the option to password protect and add the option to make this read-only with an additional password for editing. 3. Enter and confirm your passwords and save the file. 4. Reopen the file. Experienced: File is editable. Expected: File opens Read-only and Edit-Edit mode with password is needed to edit. Similar problem is with saving to PPTX and PPSX. Note that there's a different problem with PPT, LO doesn't support saving with password at all. MSO can save both file open and read-only passwords.
Confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f8bb970fd385c80b085a071da0f8acc119498005 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded and in 7.1 but not in Version: 7.0.0.2 (x64) Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c Потоков ЦП: 4; ОС: Windows 10.0 Build 19043; Отрисовка ИП: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); ИП: ru-RU Calc: threaded it's a regression another problem is even in 7.0 you don't see LO opens the password protected file as read-only, there is no any InfoBar for example
Bisected with mac64-7.2 repo: 3bda43e3bc659ee9b0380746e005ca17c5bba421 is the first bad commit commit 3bda43e3bc659ee9b0380746e005ca17c5bba421 Author: libreoffice <libreoffice@libreoffices-Mac-mini.local> Date: Sat Apr 10 05:31:23 2021 +0200 source 67ad205404211a2ae17c430a17ede6e9d04d0b7e source 67ad205404211a2ae17c430a17ede6e9d04d0b7e LibreOffice.app/Contents/Frameworks/libsclo.dylib | Bin 18529520 -> 18529536 bytes LibreOffice.app/Contents/Frameworks/libsdlo.dylib | Bin 7521596 -> 7521596 bytes .../Contents/Frameworks/libsvxcorelo.dylib | Bin 9088316 -> 9088588 bytes LibreOffice.app/Contents/Resources/setuprc | 2 +- LibreOffice.app/Contents/Resources/versionrc | 2 +- 5 files changed, 2 insertions(+), 2 deletions(-)
git bisect log: # bad: [20651168152192ab9e0f9d12a94228b24125b0d4] source 3d311c6d63eafbe2f76d6f1768dc3f675970a55a # good: [7ae9dc0eb055b3d88573a247cf3f756b06ad5cad] source 738bcf5e9a8c443d60c29c3a8068e8c16c72638a git bisect start 'master' 'oldest' # good: [de3791b1403f4e466497581e5a49f06f94701dbb] source 9279dce41152ed692c125edfed4c80a7c28c7a0b git bisect good de3791b1403f4e466497581e5a49f06f94701dbb # bad: [14ed0e5dd6bcbf3b576c3c90234fa74af8013f55] source c889431df7e77c68fe7ead9aa235a5b2f586a4c6 git bisect bad 14ed0e5dd6bcbf3b576c3c90234fa74af8013f55 # bad: [4434fb63c739c2649022898bd73706ca7021a802] source 2e8d635f7908497898c2d90b45070a3467fd15a5 git bisect bad 4434fb63c739c2649022898bd73706ca7021a802 # bad: [f7406c75c89086dabc151a226ef694d244c73847] source c0d223f7036263d3e7012d497ea71d4722052927 git bisect bad f7406c75c89086dabc151a226ef694d244c73847 # good: [69bf0590b48a8ee55106f45c613e7fe635d47009] source 6db71f70a3b200d4074f6cda8ce445e9861d3296 git bisect good 69bf0590b48a8ee55106f45c613e7fe635d47009 # bad: [f520b1b2285359fda6f8964c977d6b1c7f666cdf] source 95bb2a4fe05fe94029047d3165af21b56b7cd3e5 git bisect bad f520b1b2285359fda6f8964c977d6b1c7f666cdf # good: [2ad29bdf4242774541107ddbe15a684a293dd3a3] source 0a900287cff32c7fd94f498f8077a3a2d162e131 git bisect good 2ad29bdf4242774541107ddbe15a684a293dd3a3 # bad: [5e61548e179e51c0bd64acbd9ababd9e88a79eed] source ac0b6fb3842201e438950ea99a55ad334f8521ab git bisect bad 5e61548e179e51c0bd64acbd9ababd9e88a79eed # good: [3bc68e6f10995fc7b415ab38a70b61393e0b4532] source 56269c2856190d8ea2db561e13831f14af2aa7d7 git bisect good 3bc68e6f10995fc7b415ab38a70b61393e0b4532 # bad: [3bda43e3bc659ee9b0380746e005ca17c5bba421] source 67ad205404211a2ae17c430a17ede6e9d04d0b7e git bisect bad 3bda43e3bc659ee9b0380746e005ca17c5bba421 # good: [b3ca15e30479a504e0d03a081402bb0857e6bb08] source f4c165ac4fa85d5296d5a9ca5f507c3d52208fa7 git bisect good b3ca15e30479a504e0d03a081402bb0857e6bb08 # good: [cd68d59fdfac0135ccc7911c6049e6d0b2c45474] source 6dee2081c4dae3aaf1906130bee8d1337d5d4f07 git bisect good cd68d59fdfac0135ccc7911c6049e6d0b2c45474 # good: [7d024b8865cddc438d94dbdecb44613bd54c29c4] source aa0fb6ed5c9bd17f9fe339de981291120431c370 git bisect good 7d024b8865cddc438d94dbdecb44613bd54c29c4 # first bad commit: [3bda43e3bc659ee9b0380746e005ca17c5bba421] source 67ad205404211a2ae17c430a17ede6e9d04d0b7e
The commit seemed unrelated on quick glance, but I got the same result with linux-64-7.1 https://git.libreoffice.org/core/commit/ea9fff260129ccfa4755e96c08432252efbe5621 Adding Cc: to Samuel Mehrbrodt Is it the change in sd/source/ui/view/drviews4.cxx ?
Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/429f3d8e3eddedb7ab183b6530220bc7491302e7 tdf#144399 Don't allow editing in r/o mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/9d34b51efba7704beacc06cc93aa0bf6cf51a103 tdf#144399 Don't allow editing in r/o mode It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.