Bug 144554 - Merged cell's image background is duplicated since 7.1
Summary: Merged cell's image background is duplicated since 7.1
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0 target:7.2.2 target:7.1.7
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-09-16 18:47 UTC by Mike Kaganski
Modified: 2021-09-21 14:17 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
A file created in v.7.0 (11.25 KB, application/vnd.oasis.opendocument.text)
2021-09-16 18:47 UTC, Mike Kaganski 		Details
mergedCellWithBackgroundB.odt: counter example (11.82 KB, application/vnd.oasis.opendocument.text)
2021-09-20 08:59 UTC, Justin L 		Details
mergedCellWithBackgroundC.docx: the same commit also broke docx (4.28 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-09-20 13:00 UTC, Justin L 		Details
Work correct in writer < 7.1 and BAD in writer >=7.1 (26.65 KB, application/vnd.oasis.opendocument.text)
2021-09-21 06:03 UTC, Alexander 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2021-09-16 18:47:03 UTC 
Created attachment 175083 [details]
A file created in v.7.0

The attached file (created in 7.0) has a merged table cell with a background image. Opening it in 7.1+ gives the background repeated in the bottom half of the merged cell, as if it is a separate cell with own background property.
Comment 1 psidiumcode 2021-09-19 16:31:55 UTC 
I could not reproduce it in ver:

Version: 7.0.6.2
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded


I could reproduce it in ver:

Version: 7.1.0.0.alpha0+
Build ID: <buildversion>
CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

Bisected with Mac bisect repo 7.1 (bibisect-mac64-7.1 https://bibisect.libreoffice.org/mac64-7.1.git)
 c1f553a71172c0bf2d24e33219fcef7b56e1c383 is the first bad commit
commit c1f553a71172c0bf2d24e33219fcef7b56e1c383
Author: libreoffice <libreoffice@libreoffices-Mac-mini.local>
Date:   Sun Aug 2 12:49:36 2020 +0200

    source c016fe2b5918d6e53113e100b1126076b6e1a6a3
    
    source c016fe2b5918d6e53113e100b1126076b6e1a6a3

 LibreOffice.app/Contents/Frameworks/libswlo.dylib  | Bin 18469980 -> 18469980 bytes
 .../Contents/Resources/config/images_breeze.zip    | Bin 1861811 -> 1861811 bytes
 .../Resources/config/images_breeze_dark.zip        | Bin 1857484 -> 1857484 bytes
 .../Resources/config/images_breeze_dark_svg.zip    | Bin 1531920 -> 1531920 bytes
 .../Resources/config/images_breeze_svg.zip         | Bin 1529480 -> 1529480 bytes
 .../Contents/Resources/config/images_colibre.zip   | Bin 2730776 -> 2730776 bytes
 .../Resources/config/images_colibre_svg.zip        | Bin 2805657 -> 2805657 bytes
 .../Resources/config/images_elementary.zip         | Bin 4011601 -> 4011601 bytes
 .../Resources/config/images_elementary_svg.zip     | Bin 4989543 -> 4989543 bytes
 .../Resources/config/images_karasa_jaga.zip        | Bin 4820615 -> 4820615 bytes
 .../Resources/config/images_karasa_jaga_svg.zip    | Bin 19051896 -> 19051896 bytes
 .../Contents/Resources/config/images_sifr.zip      | Bin 2075564 -> 2075564 bytes
 .../Contents/Resources/config/images_sifr_dark.zip | Bin 2077418 -> 2077418 bytes
 .../Resources/config/images_sifr_dark_svg.zip      | Bin 1726964 -> 1726964 bytes
 .../Contents/Resources/config/images_sifr_svg.zip  | Bin 1723171 -> 1723171 bytes
 .../Contents/Resources/config/images_sukapura.zip  | Bin 3002843 -> 3002843 bytes
 .../Resources/config/images_sukapura_svg.zip       | Bin 4292030 -> 4292030 bytes
 LibreOffice.app/Contents/Resources/setuprc         |   2 +-
 LibreOffice.app/Contents/Resources/versionrc       |   2 +-
 19 files changed, 2 insertions(+), 2 deletions(-)
Comment 2 psidiumcode 2021-09-19 16:33:28 UTC 
Git bisect log

# bad: [116e9431a240e3a7c7161b9d7112c4a93c0363b3] source d5e786d78d2f72a39f02746d6e0faa04da72c60a
# good: [75306c92d72b1fb500c114873493cf9d3c824e76] source 574c57090642347980d2395e1e183cc7b5c171ad
git bisect start 'master' 'oldest'
# bad: [062dcd9049c6a969aee24685350fac959be03ee9] source a0f282f57213c4318c1de10d74ee43b850886147
git bisect bad 062dcd9049c6a969aee24685350fac959be03ee9
# good: [51742fbd21633235caf30f80dc5b71274ee772ff] source 58b4ea44865cb7a058c35edaef62576e1bbebfc7
git bisect good 51742fbd21633235caf30f80dc5b71274ee772ff
# bad: [3543654c94ec5c5c80a7c82cd51167866be6ee36] source fc7464a882f22e7974135e44867d1a183881edd9
git bisect bad 3543654c94ec5c5c80a7c82cd51167866be6ee36
# good: [03bef7423657ec3016bf5c87ba4f2ae566803816] source 7eff43375d8d1df59d4961b9e8bc5d12b3edbab6
git bisect good 03bef7423657ec3016bf5c87ba4f2ae566803816
# bad: [86c5b8550bf9b85b56580f04ef2d629d8a29dc26] source b6a4ddf4d8c45030dbe3fc68b51f9366109041bd
git bisect bad 86c5b8550bf9b85b56580f04ef2d629d8a29dc26
# bad: [c370c148e9b4506694d36cef608a89deccca7820] source 06fd06597796d9e92117602245f3968c93707708
git bisect bad c370c148e9b4506694d36cef608a89deccca7820
# bad: [44c64c53911bcd77bcc782ae02e7714476b1a044] source af2b82b4f32909dd82006e531398c68268325d24
git bisect bad 44c64c53911bcd77bcc782ae02e7714476b1a044
# good: [87b4315cda24c5cc87b9db04ffe783252a2ce77e] source b827eefd6397dc34b49a03e186146aed6cd80042
git bisect good 87b4315cda24c5cc87b9db04ffe783252a2ce77e
# bad: [1935f0e07648962bcce171c472cfd92d790add10] source 8197c3af338a20a3b99de001adc02b4329f074a7
git bisect bad 1935f0e07648962bcce171c472cfd92d790add10
# bad: [aec2b6a20958e45adb75c5798bbace1909d89116] source 7b4802070ac6fb930255536bf3ed2c52428b4181
git bisect bad aec2b6a20958e45adb75c5798bbace1909d89116
# bad: [90e448fddbc334b6f2d1a0ca8fe963417bcae4fb] source 7468d5df5ec79783eae84b62bdc5ecf12f0ca255
git bisect bad 90e448fddbc334b6f2d1a0ca8fe963417bcae4fb
# bad: [2b1674cb292c04eb28bdab33c56e34e3a52a9e26] source 6e86f77da5cf66c832f785a7f4eb806a3fdc26c6
git bisect bad 2b1674cb292c04eb28bdab33c56e34e3a52a9e26
# bad: [c1f553a71172c0bf2d24e33219fcef7b56e1c383] source c016fe2b5918d6e53113e100b1126076b6e1a6a3
git bisect bad c1f553a71172c0bf2d24e33219fcef7b56e1c383
# first bad commit: [c1f553a71172c0bf2d24e33219fcef7b56e1c383] source c016fe2b5918d6e53113e100b1126076b6e1a6a3
Comment 4 Mike Kaganski 2021-09-20 06:17:56 UTC 
(In reply to psidiumcode from comment #1)
> Bisected with Mac bisect repo 7.1
> 
>     source c016fe2b5918d6e53113e100b1126076b6e1a6a3

https://git.libreoffice.org/core/+/c016fe2b5918d6e53113e100b1126076b6e1a6a3

CCing Justin Luth; Could you please take a look?
Comment 5 Justin L 2021-09-20 08:59:51 UTC 
Created attachment 175135 [details]
mergedCellWithBackgroundB.odt: counter example

Yuck. This is not going to be pretty.

Adding a background colour to row 2 didn't work good in 7.0 in this case. So that part of the fix is still needed.
Comment 6 Justin L 2021-09-20 13:00:50 UTC 
Created attachment 175139 [details]
mergedCellWithBackgroundC.docx: the same commit also broke docx

DOCX doesn't have row-level background capabilities, so it is applied to each cell. In this case, the cell is hidden/covered but still defined, and so didn't paint itself earlier, but now it does.
Comment 7 Alexander 2021-09-21 06:03:55 UTC 
Created attachment 175154 [details]
Work correct in writer < 7.1 and BAD in writer >=7.1
Comment 8 Mike Kaganski 2021-09-21 13:48:44 UTC 
Fixed by the revert https://git.libreoffice.org/core/commit/eb830ad284f245165b6ab5e8647d48834622f2d5. Thanks Justin!