Bug 144906 - CRASH when editing date field - floating Navigator open
Summary: CRASH when editing date field - floating Navigator open
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.5.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.5.7 target:7.6...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-04 08:34 UTC by Rainer Bielefeld Retired
Modified: 2023-10-05 12:11 UTC (History)
5 users (show)

See Also:
Crash report or crash signature: ["SalInstanceTreeView::get_drag_source()"]


Attachments
sample document (1.69 MB, application/vnd.oasis.opendocument.text)
2021-10-04 08:34 UTC, Rainer Bielefeld Retired
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Bielefeld Retired 2021-10-04 08:34:03 UTC
Created attachment 175489 [details]
sample document

STR with Version: 7.1.5.2 (x64) / LibreOffice Community Build 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE Calc: threaded

0. Launch LibO, open few other documents
1. Open attached sample document
2. On page 12 ˋdouble click on one of the date fields  →  switch from fix date to date (ate changes to "today")  →  double click and switch back to fix date
3. Wait 2 ... 3 seconds, then switch to other document and start editing
   Bug: CRASH  "EXCEPTION_ACCESS_VIOLATION_READ" 😥

Additional Info
---------------
a) not 1005 reproducible. Sometimes every change causes CRASH, sometimes I can do
   dozens of changes without crash
b) affected are existing documents, I did not yet check whether also newly
   created documents are affected 
c) several additional crash reports within the last 2 hours!
d) I can't tell with which version this started.
e) happens on my brand-new Ryzen WIN10 machine, was also a problem on my old
   WIN7 Phenomenon PC.
Comment 1 Xisco Faulí 2021-10-11 08:49:20 UTC
I can't reproduce it in

Version: 7.2.1.2 (x86) / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded
Comment 2 Rainer Bielefeld Retired 2021-10-11 08:58:26 UTC
Might be related to my user profile. Or fixed in 7.2?

I will to tests with sample document,  7.2 and/or newly created user profile, soon.
Comment 3 Rainer Bielefeld Retired 2021-10-24 17:35:18 UTC
No longer reproducible with 
Version: 7.2.1.2 (x64) / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 4 Rainer Bielefeld Retired 2021-11-09 18:59:42 UTC
It's not really WFM, I still have a crash from time to time editing Date fields in existing old Documents with Installation of Version:7.2.1.2 (x64); Build ID: 87b77fad49947c1441b67c559c339af8f3517e22; CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded, mystandard User Profile. 

For example <https://crashreport.libreoffice.org/stats/crash_details/7152e7fd-886e-4cd9-9646-f9d5e4364f78>
Comment 6 Rainer Bielefeld Retired 2022-10-28 07:44:02 UTC
Still see that problem. Writer does not always crash, but distinctive often.
for example https://crashreport.libreoffice.org/stats/crash_details/3126657f-ec94-4ad4-abbc-bf054f488256

Possibly related Bugs in this Query: <https://bugs.documentfoundation.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs144906&sharer_id=19321>
Comment 7 Caolán McNamara 2022-12-16 21:59:18 UTC
Seeing as the bt suggests SwContentTree is involved, is there a floating Navigator open at the time (the one from F5) or a Navigator open in the sidebar?
Comment 8 sdc.blanco 2023-08-25 08:13:29 UTC
(In reply to Caolán McNamara from comment #7)

I get the same crashreport [1] from time to time. Not from editing date fields though. This latest version happened after I was editing cross-reference fields.
As noted in comment 6, only crashes occasionally, but with the distinctive crashreport (such as [1]).

> Seeing as the bt suggests SwContentTree is involved, is there a floating
> Navigator open at the time (the one from F5) or a Navigator open in the
> sidebar?
Yes.  There was definitely a floating Navigator open with the crash in [1].

[1] https://crashreport.libreoffice.org/stats/crash_details/6d3bb8fb-c894-478c-90f9-4c7d0c35ad82
Comment 9 Commit Notification 2023-08-28 10:22:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/df3b95a39472e18ea8acdaae447b7176e37a9256

Related: tdf#144906 unset g_DragSource if drag end callback never called

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-08-28 11:49:22 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/48e3c7c7b115c08af80752af8f7302447872300b

Related: tdf#144906 unset g_DragSource if drag end callback never called

It will be available in 7.5.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-08-28 13:00:34 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5431abc55c5e02cf6a0f68b8ce40826d85e43006

Related: tdf#144906 unset g_DragSource if drag end callback never called

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-08-30 10:28:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5-6":

https://git.libreoffice.org/core/commit/a2e8617140e924e33c2b157964244e12de508c91

Related: tdf#144906 unset g_DragSource if drag end callback never called

It will be available in 7.5.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2023-09-05 13:55:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-1":

https://git.libreoffice.org/core/commit/f3d85930ead7e62225646a992dbd22af822122af

Related: tdf#144906 unset g_DragSource if drag end callback never called

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 BogdanB 2023-10-04 16:27:59 UTC
Rainer, could you reproduce this bug now?
Comment 15 Xisco Faulí 2023-10-05 12:11:31 UTC
Looking at https://crashreport.libreoffice.org/stats/signature/SalInstanceTreeView::get_drag_source()#summary, the crash is no longer reported for 7.5.6, 7.5.7, 7.6.1 or 7.6.2 so we can assume this issue is fixed.

@Caolán, thanks a lot for fixing this!!